You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Fang Wang <fa...@citrix.com> on 2012/09/12 01:00:27 UTC
Review Request: Keep the instance-id and vm-id values prior to Acton,
use UUID for VMs created poast Acton.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7045/
-----------------------------------------------------------
Review request for cloudstack and Alena Prokharchyk.
Description
-------
We keep the original instance-id and vm-id value assigned prior to Acton, and only use UUID for new resources created post Acton.
This addresses bug cs-15627.
Diffs
-----
server/src/com/cloud/network/element/CloudZonesNetworkElement.java 0d4c1c1
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 613548b
Diff: https://reviews.apache.org/r/7045/diff/
Testing
-------
Thanks,
Fang Wang
Re: Review Request: Keep the instance-id and vm-id values prior to Acton,
use UUID for VMs created poast Acton.
Posted by Fang Wang <fa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7045/
-----------------------------------------------------------
(Updated Sept. 13, 2012, 5:54 p.m.)
Review request for cloudstack and Alena Prokharchyk.
Description
-------
We keep the original instance-id and vm-id value assigned prior to Acton, and only use UUID for new resources created post Acton.
This addresses bug cs-15627.
Diffs
-----
server/src/com/cloud/network/element/CloudZonesNetworkElement.java 0d4c1c1
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 613548b
Diff: https://reviews.apache.org/r/7045/diff/
Testing (updated)
-------
1. tested on system upgrade;
2. on new system, null the uuid of the vm, and test the output of instance_id and vm_id.
Thanks,
Fang Wang
Re: Review Request: Keep the instance-id and vm-id values prior to Acton,
use UUID for VMs created poast Acton.
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7045/#review11365
-----------------------------------------------------------
Ship it!
Ship It!
- Alena Prokharchyk
On Sept. 11, 2012, 11 p.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7045/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2012, 11 p.m.)
>
>
> Review request for cloudstack and Alena Prokharchyk.
>
>
> Description
> -------
>
> We keep the original instance-id and vm-id value assigned prior to Acton, and only use UUID for new resources created post Acton.
>
>
> This addresses bug cs-15627.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/element/CloudZonesNetworkElement.java 0d4c1c1
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 613548b
>
> Diff: https://reviews.apache.org/r/7045/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fang Wang
>
>