You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by ha...@apache.org on 2025/10/22 12:12:16 UTC
(hop) branch main updated: Fixes missing parts cleaning icons #5856 (#5864)
This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/main by this push:
new 3943cb0b67 Fixes missing parts cleaning icons #5856 (#5864)
3943cb0b67 is described below
commit 3943cb0b67964b14d1e932a893ad19b0021ca8c1
Author: Nicolas Adment <39...@users.noreply.github.com>
AuthorDate: Wed Oct 22 14:12:09 2025 +0200
Fixes missing parts cleaning icons #5856 (#5864)
Co-authored-by: Hans Van Akelyen <ha...@gmail.com>
---
.../apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java | 2 +-
.../apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java | 2 +-
.../hop/ui/hopgui/perspective/execution/ExecutionPerspective.java | 8 +++++---
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java b/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
index 3bea8be9a2..af10df8161 100644
--- a/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
+++ b/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/HopGuiPipelineGraph.java
@@ -2224,7 +2224,7 @@ public class HopGuiPipelineGraph extends HopGuiAbstractGraph
type = GuiActionType.Modify,
name = "i18n::HopGuiPipelineGraph.TransformAction.EditDescription.Name",
tooltip = "i18n::HopGuiPipelineGraph.TransformAction.EditDescription.Tooltip",
- image = "ui/images/edit.svg",
+ image = "ui/images/edit-description.svg",
category = "Basic",
categoryOrder = "1")
public void editDescription(HopGuiPipelineTransformContext context) {
diff --git a/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java b/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
index 85fc02738e..5b2c7aa877 100644
--- a/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
+++ b/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/HopGuiWorkflowGraph.java
@@ -1846,7 +1846,7 @@ public class HopGuiWorkflowGraph extends HopGuiAbstractGraph
type = GuiActionType.Modify,
name = "i18n::HopGuiWorkflowGraph.ContextualAction.EditActionDescription.Text",
tooltip = "i18n::HopGuiWorkflowGraph.ContextualAction.EditActionDescription.Tooltip",
- image = "ui/images/edit.svg",
+ image = "ui/images/edit-description.svg",
category = "i18n::HopGuiWorkflowGraph.ContextualAction.Category.Basic.Text",
categoryOrder = "1")
public void editActionDescription(HopGuiWorkflowActionContext context) {
diff --git a/ui/src/main/java/org/apache/hop/ui/hopgui/perspective/execution/ExecutionPerspective.java b/ui/src/main/java/org/apache/hop/ui/hopgui/perspective/execution/ExecutionPerspective.java
index f2ae59e666..448f6b3fbf 100644
--- a/ui/src/main/java/org/apache/hop/ui/hopgui/perspective/execution/ExecutionPerspective.java
+++ b/ui/src/main/java/org/apache/hop/ui/hopgui/perspective/execution/ExecutionPerspective.java
@@ -267,19 +267,21 @@ public class ExecutionPerspective implements IHopPerspective, TabClosable {
//
ToolBar toolBar = new ToolBar(tabFolder, SWT.FLAT);
final ToolItem item = new ToolItem(toolBar, SWT.PUSH);
- item.setImage(GuiResource.getInstance().getImageMinimizePanel());
+ item.setImage(GuiResource.getInstance().getImageMaximizePanel());
item.addListener(
SWT.Selection,
e -> {
if (sash.getMaximizedControl() == null) {
sash.setMaximizedControl(tabFolder);
- item.setImage(GuiResource.getInstance().getImageMaximizePanel());
+ item.setImage(GuiResource.getInstance().getImageMinimizePanel());
} else {
sash.setMaximizedControl(null);
- item.setImage(GuiResource.getInstance().getImageMinimizePanel());
+ item.setImage(GuiResource.getInstance().getImageMaximizePanel());
}
});
tabFolder.setTopRight(toolBar, SWT.RIGHT);
+ int height = toolBar.computeSize(SWT.DEFAULT, SWT.DEFAULT).y;
+ tabFolder.setTabHeight(Math.max(height, tabFolder.getTabHeight()));
new TabCloseHandler(this);