You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/04/26 17:00:53 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1592: SOLR-16394: Tweak v2 restore-coll to be more REST-ful
gerlowskija opened a new pull request, #1592:
URL: https://github.com/apache/solr/pull/1592
https://issues.apache.org/jira/browse/SOLR-16394
# Description
Solr is currently making slow progress in moving its v2 APIs in a more REST-ful direction. Many APIs have been improved, but many remaining including the API to restore to a new or existing collection.
# Solution
This commit makes various cosmetic improvements to Solr's v2 restore-collection API, to bring it more into line with the more REST-ful v2 design. This mostly consists of moving the API under the /api/backups/backupName/restore path, and removing the top-level "command" specification from the request body.
# Tests
Existing tests continue to pass. New unit tests in RestoreCollectionAPITest.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1592: SOLR-16394: Tweak v2 restore-coll to be more REST-ful
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1592:
URL: https://github.com/apache/solr/pull/1592#issuecomment-1523765458
Excepting a few new tests added here, all of this code comes from a pre-existing PR: #1453 .
Since the code has been available for review for several weeks there, I'll aim to merge this sometime in the next few days once I'm confident that the tests look good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1592: SOLR-16394: Tweak v2 restore-coll to be more REST-ful
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1592:
URL: https://github.com/apache/solr/pull/1592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org