You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/07/10 11:48:40 UTC
Re: Review Request 67503: Added helper for fetching review id
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/#review205905
-----------------------------------------------------------
The commit message should be edited to finish with a period and the Testing Done part should be filled even if it's just to say that tests have been done later in the chain.
support/python3/get-review-ids.py
Lines 19 (patched)
<https://reviews.apache.org/r/67503/#comment288803>
Add a newline here, it's either:
```
"""Hello"""
```
or
```
"""
Lorem ipsum dolor sit amet, consectetur adipiscing elit.
Etiam lectus orci, sodales a est in, vulputate egestas turpis.
Quisque quis rhoncus elit.
"""
```
Also, s/`This file is used to get the`/`This script gets`.
support/python3/get-review-ids.py
Lines 30 (patched)
<https://reviews.apache.org/r/67503/#comment288804>
Missing period.
support/python3/get-review-ids.py
Lines 41 (patched)
<https://reviews.apache.org/r/67503/#comment288805>
Add a newline after the `""""`.
support/python3/get-review-ids.py
Lines 42 (patched)
<https://reviews.apache.org/r/67503/#comment288806>
Missing period.
support/python3/get-review-ids.py
Lines 49 (patched)
<https://reviews.apache.org/r/67503/#comment288807>
What happens if `--out-file` is not used?
- Armand Grillet
On June 14, 2018, 11:13 p.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67503/
> -----------------------------------------------------------
>
> (Updated June 14, 2018, 11:13 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helper for fetching review id
>
>
> Diffs
> -----
>
> support/python3/get-review-ids.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67503/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dragos Schebesch
>
>