You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2005/05/26 09:23:43 UTC

DO NOT REPLY [Bug 35082] New: - Incorrect definition of BOOL

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35082>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35082

           Summary: Incorrect definition of BOOL
           Product: Apache httpd-2.0
           Version: 2.0.54
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: P1
         Component: mod_ssl
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: mstern@csc.com


In mod_ssl.h, BOOL is defined as "unsigned int".
Some mod_ssl parameters are defined as BOOL:
    struct SSLSrvConfigRec {
        SSLModConfigRec *mc;
        BOOL             enabled;
        BOOL             proxy_enabled;
        const char      *vhost_id;
        int              vhost_id_len;
        int              session_cache_timeout;
        modssl_ctx_t    *server;
        modssl_ctx_t    *proxy;
    };
In ssl_config.c, the parameters are initialized with UNSET:
    sc->enabled                = UNSET;
    sc->proxy_enabled          = UNSET;

UNSET is defined as -1 ==> signed/unsigned problem
 
Shouldn't we change the BOOL definition to signed int ?
 
Rem: On some compilers, BOOL may be already defined, so the run-time libraries
definition is used instead of mod_ssl one, but not with, for example, VC++

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org