You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2016/03/04 18:57:41 UTC
[jira] [Updated] (LUCENE-6952) All Filter* delegating classes
should be abstract
[ https://issues.apache.org/jira/browse/LUCENE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated LUCENE-6952:
---------------------------------
Assignee: David Smiley
Description: I think it's confusing that FilterLeafReader (and it's Filter\* inner classes) are not abstract. By making them abstract, we clarify to users how to use them by virtue of them being abstract. It seems only a couple tests directly instantiate them. This applies to other Filter* classes as well. (was: I think it's confusing that FilterLeafReader (and it's Filter\* inner classes) are not abstract. By making them abstract, we clarify to users how to use them by virtue of them being abstract. It seems only a couple tests directly instantiate them.)
Summary: All Filter* delegating classes should be abstract (was: FilterLeafReader and friends should be abstract)
> All Filter* delegating classes should be abstract
> -------------------------------------------------
>
> Key: LUCENE-6952
> URL: https://issues.apache.org/jira/browse/LUCENE-6952
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: master
>
> Attachments: LUCENE_6952.patch
>
>
> I think it's confusing that FilterLeafReader (and it's Filter\* inner classes) are not abstract. By making them abstract, we clarify to users how to use them by virtue of them being abstract. It seems only a couple tests directly instantiate them. This applies to other Filter* classes as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Updated] (LUCENE-6952) All Filter* delegating classes
should be abstract
Posted by David Smiley <da...@gmail.com>.
Can someone look this over so it can be considered for 6.0? It should be
easy to review; not much to it.
On Fri, Mar 4, 2016 at 12:57 PM David Smiley (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/LUCENE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> David Smiley updated LUCENE-6952:
> ---------------------------------
> Assignee: David Smiley
> Description: I think it's confusing that FilterLeafReader (and it's
> Filter\* inner classes) are not abstract. By making them abstract, we
> clarify to users how to use them by virtue of them being abstract. It
> seems only a couple tests directly instantiate them. This applies to other
> Filter* classes as well. (was: I think it's confusing that
> FilterLeafReader (and it's Filter\* inner classes) are not abstract. By
> making them abstract, we clarify to users how to use them by virtue of them
> being abstract. It seems only a couple tests directly instantiate them.)
> Summary: All Filter* delegating classes should be abstract (was:
> FilterLeafReader and friends should be abstract)
>
> > All Filter* delegating classes should be abstract
> > -------------------------------------------------
> >
> > Key: LUCENE-6952
> > URL: https://issues.apache.org/jira/browse/LUCENE-6952
> > Project: Lucene - Core
> > Issue Type: Improvement
> > Reporter: David Smiley
> > Assignee: David Smiley
> > Priority: Minor
> > Fix For: master
> >
> > Attachments: LUCENE_6952.patch
> >
> >
> > I think it's confusing that FilterLeafReader (and it's Filter\* inner
> classes) are not abstract. By making them abstract, we clarify to users
> how to use them by virtue of them being abstract. It seems only a couple
> tests directly instantiate them. This applies to other Filter* classes as
> well.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
> --
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com