You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/11/04 16:49:50 UTC

[kudu-CR] [java client] Cleanup "Connection reset" message in TabletClient

Hello Adar Dembo, Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4947

to review the following change.

Change subject: [java client] Cleanup "Connection reset" message in TabletClient
......................................................................

[java client] Cleanup "Connection reset" message in TabletClient

It was adding a Channel.toString() which has never been useful, removing.

Change-Id: I4c47df9dbd7183a328fe15cabc2e7a137c6d2184
---
M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/4947/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c47df9dbd7183a328fe15cabc2e7a137c6d2184
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [java client] Cleanup "Connection reset" message in TabletClient

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.

Change subject: [java client] Cleanup "Connection reset" message in TabletClient
......................................................................


[java client] Cleanup "Connection reset" message in TabletClient

It was adding a Channel.toString() which has never been useful, removing.

Change-Id: I4c47df9dbd7183a328fe15cabc2e7a137c6d2184
Reviewed-on: http://gerrit.cloudera.org:8080/4947
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c47df9dbd7183a328fe15cabc2e7a137c6d2184
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java client] Cleanup "Connection reset" message in TabletClient

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: [java client] Cleanup "Connection reset" message in TabletClient
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c47df9dbd7183a328fe15cabc2e7a137c6d2184
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No