You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ta...@apache.org on 2018/10/29 13:50:01 UTC
[myfaces] branch 2.3.x updated: MYFACES-4189 Multi valued query
parameter not considered in commandbutton action
This is an automated email from the ASF dual-hosted git repository.
tandraschko pushed a commit to branch 2.3.x
in repository https://gitbox.apache.org/repos/asf/myfaces.git
The following commit(s) were added to refs/heads/2.3.x by this push:
new 8c1c6fa MYFACES-4189 Multi valued query parameter not considered in commandbutton action
8c1c6fa is described below
commit 8c1c6fa00dda3cf0a95a47f71d568e5dce71b080
Author: Thomas Andraschko <ta...@apache.org>
AuthorDate: Mon Oct 29 14:49:55 2018 +0100
MYFACES-4189 Multi valued query parameter not considered in commandbutton action
---
.../context/servlet/ServletExternalContextImpl.java | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java b/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java
index a67fc6a..c74f2d6 100755
--- a/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java
+++ b/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java
@@ -885,11 +885,23 @@ public final class ServletExternalContextImpl extends ServletExternalContextImpl
for (int i = 0; i < nameValuePairs.length; i++)
{
String[] currentPair = nameValuePairs[i].split(URL_NAME_VALUE_PAIR_SEPERATOR);
+ String currentName = currentPair[0];
- ArrayList<String> value = new ArrayList<String>(1);
+ if (paramMap == null)
+ {
+ paramMap = new HashMap<String, List<String>>();
+ }
+
+ List<String> values = paramMap.get(currentName);
+ if (values == null)
+ {
+ values = new ArrayList<>(1);
+ paramMap.put(currentName, values);
+ }
+
try
{
- value.add(currentPair.length > 1
+ values.add(currentPair.length > 1
? URLDecoder.decode(currentPair[1], getResponseCharacterEncoding())
: "");
}
@@ -899,11 +911,6 @@ public final class ServletExternalContextImpl extends ServletExternalContextImpl
throw new UnsupportedOperationException("Encoding type=" + getResponseCharacterEncoding()
+ " not supported", e);
}
- if (paramMap == null)
- {
- paramMap = new HashMap<String, List<String>>();
- }
- paramMap.put(currentPair[0], value);
}
}