You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2017/03/21 21:41:02 UTC
[GitHub] cordova-lib pull request #530: CB-10438 : Install correct dependency version
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/530
CB-10438 : Install correct dependency version
requires force to install plugin with wrong dependency version installed.
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Install correct dependency version.
Requires force to install plugin with wrong dependency version installed.
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-10438
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/530.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #530
----
commit 06ebb7516976370e9a4322b12cca5c79f89a5a2a
Author: carynbear <ca...@berkeley.edu>
Date: 2016-06-07T00:21:02Z
CB-10438 :Install correct dependency version, requires force to install plugin with wrong dependency version installed. Also, removed shell.remove, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js and update to workw with jasmine 2.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #530: CB-10438 : Install correct dependency version
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/530
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=h1) Report
> Merging [#530](https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/da952e074d36bd917beb041dc4e49abc760f5561?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `95.45%`.
```diff
@@ Coverage Diff @@
## master #530 +/- ##
==========================================
+ Coverage 82.13% 82.17% +0.04%
==========================================
Files 68 68
Lines 5498 5516 +18
Branches 1087 1096 +9
==========================================
+ Hits 4516 4533 +17
- Misses 982 983 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/plugman/plugman.js](https://codecov.io/gh/apache/cordova-lib/compare/da952e074d36bd917beb041dc4e49abc760f5561...06ebb7516976370e9a4322b12cca5c79f89a5a2a?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGx1Z21hbi5qcw==) | `28.44% <0%> (-0.27%)` | :arrow_down: |
| [cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/da952e074d36bd917beb041dc4e49abc760f5561...06ebb7516976370e9a4322b12cca5c79f89a5a2a?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `87.78% <100%> (+0.7%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=footer). Last update [da952e0...06ebb75](https://codecov.io/gh/apache/cordova-lib/compare/da952e074d36bd917beb041dc4e49abc760f5561...06ebb7516976370e9a4322b12cca5c79f89a5a2a?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #530: CB-10438 : Install correct dependency version
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #530: CB-10438 : Install correct dependency version
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/530
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #530: CB-10438 : Install correct dependency version
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/530
Rebased after CB-11346 was merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #530: CB-10438 : Install correct dependency version
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso closed the pull request at:
https://github.com/apache/cordova-lib/pull/530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #530: CB-10438 : Install correct dependency version
Posted by audreyso <gi...@git.apache.org>.
GitHub user audreyso reopened a pull request:
https://github.com/apache/cordova-lib/pull/530
CB-10438 : Install correct dependency version
requires force to install plugin with wrong dependency version installed.
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Install correct dependency version.
Requires force to install plugin with wrong dependency version installed.
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-10438
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/530.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #530
----
commit 06ebb7516976370e9a4322b12cca5c79f89a5a2a
Author: carynbear <ca...@berkeley.edu>
Date: 2016-06-07T00:21:02Z
CB-10438 :Install correct dependency version, requires force to install plugin with wrong dependency version installed. Also, removed shell.remove, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js and update to workw with jasmine 2.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org