[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #24205: feat(sqllab): SQLEditor Extension

["Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>]

Antonio-RiveroMartnez commented on code in PR #24205:
URL: https://github.com/apache/superset/pull/24205#discussion_r1213330730


##########
superset-frontend/src/SqlLab/components/SqlEditor/index.jsx:
##########
@@ -673,6 +684,15 @@ const SqlEditor = ({
         onDragEnd={onResizeEnd}
       >
         <div ref={northPaneRef} className="north-pane">
+          {SqlFormExtension && (
+            <SqlFormExtension
+              queryEditorId={queryEditor.id}
+              setQueryEditorAndSaveSqlWithDebounce={

Review Comment:
   Hey @geido good call! I understand we want to keep the extension with as little props/dependencies as possible, but for example in the case of `startQuery`, it needs to dispatch two actions in the main component, so, right now I don't see a clearer way than passing the whole callback, like we do on other extensions like SSHTunneling, DBT etc. But If anyone has an idea on how this might work, I'm more than happy to discuss. Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org