You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/05/06 21:19:22 UTC
Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding
code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20648/#review42342
-----------------------------------------------------------
Ping? Any new thoughts or prevailing dislike for this change?
- Bill Farner
On April 24, 2014, 4:22 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20648/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 4:22 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-340
> https://issues.apache.org/jira/browse/AURORA-340
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove IsolatedSchedulerModule and surrounding code.
>
>
> Diffs
> -----
>
> build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8
> src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9
> src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 1bfd4b69584122f62616ce93098a56fe3cf195d8
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 9186aebef2babc4a76fe05eb3b412be26d7de3c6
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6
> src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java cc31187607e89a9daebe071a8a180d56d873e4c5
>
> Diff: https://reviews.apache.org/r/20648/diff/
>
>
> Testing
> -------
>
> ./gradlew build
> sh examples/vagrant/test_tutorial.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding
code.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On May 6, 2014, 7:19 p.m., Bill Farner wrote:
> > Ping? Any new thoughts or prevailing dislike for this change?
My thoughts are the same :) I would prefer having a gradual transition to vagrant rather than stimulate_via_cutting_the_cord approach.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20648/#review42342
-----------------------------------------------------------
On April 24, 2014, 4:22 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20648/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 4:22 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-340
> https://issues.apache.org/jira/browse/AURORA-340
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove IsolatedSchedulerModule and surrounding code.
>
>
> Diffs
> -----
>
> build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8
> src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9
> src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 1bfd4b69584122f62616ce93098a56fe3cf195d8
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 9186aebef2babc4a76fe05eb3b412be26d7de3c6
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6
> src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java cc31187607e89a9daebe071a8a180d56d873e4c5
>
> Diff: https://reviews.apache.org/r/20648/diff/
>
>
> Testing
> -------
>
> ./gradlew build
> sh examples/vagrant/test_tutorial.sh
>
>
> Thanks,
>
> Bill Farner
>
>