You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2008/04/08 02:24:58 UTC
DO NOT REPLY [Bug 44772] New: task provides no mechanism to
fail on error
https://issues.apache.org/bugzilla/show_bug.cgi?id=44772
Summary: <patch> task provides no mechanism to fail on error
Product: Ant
Version: 1.7Alpha (nightly)
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Core tasks
AssignedTo: notifications@ant.apache.org
ReportedBy: mdb@threerings.net
Created an attachment (id=21787)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21787)
A patch that always fails when the patch command fails.
The <patch> task does not fail if the invocation of the patch command fails.
Attached are two patches for <patch>:
1. A patch that simply fails the build when the patch command returns a failure
result code. This patch changes the default behavior of patch to fail when the
patch command fails, which I think is a good thing but may not be the
prevailing wisdom of the Ant project since nearly nothing fails on error by
default.
2. A patch that adds a "failOnError" attribute to the <patch> task which
defaults to false, but when set to true fails the build when the patch command
returns a failure result code.
Actually, it seems that I can only add a single attachment. I will add the
first attachment and then hopefully there will be a way to add additional
attachments once I file this report.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44772] task provides no mechanism to fail
on error
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44772
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gthb@dimon.is
--- Comment #3 from Stefan Bodewig <bo...@apache.org> 2009-08-17 01:51:38 PDT ---
*** Bug 23540 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44772] task provides no mechanism to fail
on error
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44772
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |enhancement
Status|NEW |RESOLVED
Keywords| |PatchAvailable
Resolution| |FIXED
Target Milestone|--- |1.8.0
--- Comment #2 from Stefan Bodewig <bo...@apache.org> 2008-09-16 02:02:06 PST ---
svn revision 695779 contains your second patch since backwards compatibility
sometimes is more important than having the correct defaults.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44772] task provides no mechanism to fail
on error
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44772
--- Comment #1 from Michael Bayne <md...@threerings.net> 2008-04-07 17:25:38 PST ---
Created an attachment (id=21788)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21788)
A patch that introduces a failOnError attribute to <patch>.
This and the previous patch are against the 20080407 nightly code snapshot.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.