You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/01/04 00:04:11 UTC
Re: Review Request 69436: Fixed flaky check in cluster::Slave
destructor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69436/#review211662
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/cluster.cpp
Lines 691 (patched)
<https://reviews.apache.org/r/69436/#comment297119>
Extra space.
src/tests/cluster.cpp
Lines 692 (patched)
<https://reviews.apache.org/r/69436/#comment297120>
s/containerizers/containerizer's/
- Greg Mann
On Nov. 22, 2018, 7:43 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69436/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2018, 7:43 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9272
> https://issues.apache.org/jira/browse/MESOS-9272
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The destructor of `cluster::Slave` contained an assertion
> that was not safe to assume in the presence of the
> composing containerizer. This commit adds an additional
> `Clock::settle()` to fix the issue.
>
>
> Diffs
> -----
>
> src/tests/cluster.cpp 2b351ca70d8e80008e49722aa7d46918b5ecd9b0
>
>
> Diff: https://reviews.apache.org/r/69436/diff/1/
>
>
> Testing
> -------
>
> Ran `./src/mesos-tests --gtest_filter="SlaveTest.DefaultExecutorCommandInfo" --verbose --gtest_repeat=50000 --gtest_throw_on_failure` while simulatenously running `stress-ng --random 64` on the same machine.
>
> (before the change, `SlaveTest.DefaultExecutorCommandInfo` would fail roughly once every 15000 runs without `stress-ng` and roughly once every 300 runs with `stress-ng`)
>
>
> Thanks,
>
> Benno Evers
>
>