You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/08/01 03:37:35 UTC

[GitHub] [dubbo-go] Mulavar commented on pull request #2001: Fix: token filter type assertion

Mulavar commented on PR #2001:
URL: https://github.com/apache/dubbo-go/pull/2001#issuecomment-1200658030

   I'm sorry that issue #1998 has been fixed, the purpose of this pr is the same as the other pr #1999 .
   I saw your pr, and maybe you forgot that the token filter should be compatible with the dubbo protocol too, so we need to check both type assertion with string and []string.
   @AnneYang720 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org