You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/05 15:03:03 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #38519: [MINOR][SQL] Remove unused an error class and query error methods
MaxGekk opened a new pull request, #38519:
URL: https://github.com/apache/spark/pull/38519
### What changes were proposed in this pull request?
In the PR, I propose to remove the unused error class `CANNOT_INFER_DATE` and some unused methods/parameters from `QueryExecutionErrors` and `QueryCompilationErrors`.
### Why are the changes needed?
To improve code maintainability.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By existing tests, GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38519: [MINOR][SQL] Remove unused an error class and query error methods
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38519:
URL: https://github.com/apache/spark/pull/38519#issuecomment-1305147588
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38519: [MINOR][SQL] Remove unused an error class and query error methods
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38519:
URL: https://github.com/apache/spark/pull/38519#issuecomment-1304866695
@panbingkun @LuciferYang @itholic @cloud-fan @srielau Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38519: [MINOR][SQL] Remove unused an error class and query error methods
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38519: [MINOR][SQL] Remove unused an error class and query error methods
URL: https://github.com/apache/spark/pull/38519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38519: [MINOR][SQL] Remove unused an error class and query error methods
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38519:
URL: https://github.com/apache/spark/pull/38519#issuecomment-1305144565
Merging to master. Thank you, @itholic for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org