You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "thurka (via GitHub)" <gi...@apache.org> on 2023/05/03 10:36:26 UTC
[GitHub] [netbeans] thurka opened a new pull request, #5914: lower the OS level memory consumption of NB LSP
thurka opened a new pull request, #5914:
URL: https://github.com/apache/netbeans/pull/5914
Cherry-picked https://github.com/apache/netbeans/pull/5909 from master to delivery.
(cherry picked from commit 879061efcae9c68081feae717c0517c975057237)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5914:
URL: https://github.com/apache/netbeans/pull/5914#issuecomment-1539896132
@MartinBalin OK, sync will merge cleanly as I hoped, so only downside is the commit will be in master history twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5914:
URL: https://github.com/apache/netbeans/pull/5914#issuecomment-1536972573
not sure if this will help, but we could add a few notes to the reviewer guide:
https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] MartinBalin commented on pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on PR #5914:
URL: https://github.com/apache/netbeans/pull/5914#issuecomment-1540085873
@neilcsmith-net thank's for merging. Re where to document how to target PR when there is a release branch already and you want to merge to both should not this be mentioned here? https://cwiki.apache.org/confluence/display/NETBEANS/Submitting+Pull+Requests I can update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5914:
URL: https://github.com/apache/netbeans/pull/5914#issuecomment-1532840471
@thurka we don't generally cherry pick from master to delivery. If this change was meant for NB18 it should have been opened and reviewed against delivery in the first place. It's doable, but will require extra work to sync delivery back into master. cc/ @MartinBalin for a call on that. Should merge as late as we can or it will break other CI testing against master in #5908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5914:
URL: https://github.com/apache/netbeans/pull/5914#issuecomment-1540142265
I linked the delivery wiki page now from here too:
https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide
and I added screenshots which hopefully increases the probability of someone reading it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5914:
URL: https://github.com/apache/netbeans/pull/5914#issuecomment-1533547306
> How does the cherry picked commit from master to delivery requires syncing delivery back to master? Sorry, I don't understand.
Delivery always syncs to master weekly. If we cherry pick from master into delivery we end up with it in master twice via two different commits, and therefore need to handle the merge conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] MartinBalin commented on pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on PR #5914:
URL: https://github.com/apache/netbeans/pull/5914#issuecomment-1536091673
Thank you very much Neil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5914:
URL: https://github.com/apache/netbeans/pull/5914#issuecomment-1540098449
@MartinBalin it's mentioned in every [NOTICE] email, as in the one linked above, and there's additional information on the other wiki page I linked too. We could add information from both the links to the Submitting Pull Requests page. Assuming that gets read! :smile:
The key thing is that paying attention to [NOTICE] emails on dev@ (even if nothing else) should be a pre-requisite for committing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net merged PR #5914:
URL: https://github.com/apache/netbeans/pull/5914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] MartinBalin commented on pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on PR #5914:
URL: https://github.com/apache/netbeans/pull/5914#issuecomment-1533532173
@neilcsmith-net I forgot to mention to Tomas it has to go to delivery, forgot thing which is obvious for me. How does the cherry picked commit from master to delivery requires syncing delivery back to master? Sorry, I don't understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5914: lower the OS level memory consumption of NB LSP
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5914:
URL: https://github.com/apache/netbeans/pull/5914#issuecomment-1537094907
> not sure if this will help, but we could add a few notes to the reviewer guide: https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide
@mbien yes. Going slightly off-topic, but consolidating / linking the text from the [NOTICE] emails and the page on PRs to delivery would be good.
https://lists.apache.org/thread/2c0nlt35xo01p4k8r6gtktqmt9tjcvtx
https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery
And that tracking [NOTICE] emails is a prerequisite for any committer (that was why we started using the tag in the first place).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists