You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by mingzym <gi...@git.apache.org> on 2016/04/21 09:38:17 UTC
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
GitHub user mingzym opened a pull request:
https://github.com/apache/trafficserver/pull/593
TS-4156: remove the traffic_sac, stand alone log collation server
TS-4156: remove the traffic_sac, stand alone log collation server
https://issues.apache.org/jira/browse/TS-4156
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mingzym/trafficserver TS-4156
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/593.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #593
----
commit 5b64c248f8006517789fd7f630b8f5b8ca2dc0ba
Author: Zhao Yongming <mi...@gmail.com>
Date: 2016-01-28T01:07:18Z
TS-4156: remove the traffic_sac, stand alone log collation server
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-219186495
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-218576777
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #593: TS-4156: remove the traffic_sac, stand alon...
Posted by mingzym <gi...@git.apache.org>.
Github user mingzym closed the pull request at:
https://github.com/apache/trafficserver/pull/593
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-216085057
@masaori335 ``doc/locale/ja/LC_MESSAGES/admin/working-log-files.en.po`` needs to be regenerated after this change. Can you document how to do that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-219191871
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #593: TS-4156: remove the traffic_sac, stand alone log c...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on the issue:
https://github.com/apache/trafficserver/pull/593
@mingzym I'll update Japanese docs after this is merged if you want :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #593: TS-4156: remove the traffic_sac, stand alone log c...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on the issue:
https://github.com/apache/trafficserver/pull/593
I updated PO files in 0ebfab01d909bcd0d99cd2f8fb2f816916bc80f3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-220376308
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-218578787
Linux (CentOS7) build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-Linux/12/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-219194918
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-216432563
Here is the docs : [Internationalize Documentation - Update PO files](https://cwiki.apache.org/confluence/display/TS/Internationalize+Documentation#InternationalizeDocumentation-UpdatePOfiles)
Please use `ja` as `<LANG>`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-219190145
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #593: TS-4156: remove the traffic_sac, stand alone log c...
Posted by mingzym <gi...@git.apache.org>.
Github user mingzym commented on the issue:
https://github.com/apache/trafficserver/pull/593
@masaori335 here we go :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-214041764
Could you please remove these remaining references:
```
$ git grep traffic_sac
.gitignore:proxy/traffic_sac
doc/locale/ja/LC_MESSAGES/admin/working-log-files.en.po:"Copy the :program:`traffic_sac` binary from the Traffic Server ``bin`` "
doc/locale/ja/LC_MESSAGES/admin/working-log-files.en.po:"program:`traffic_sac` binary."
```
Otherwise, this looks OK, and no-one has stepped up in favor of ``traffic_sac``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #593: TS-4156: remove the traffic_sac, stand alone log c...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/593
@mingzym Is this going to land? Needs a rebase before you can merge this too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-218782581
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/593#issuecomment-217457973
@mingzym I think you are OK to make this change, but unless I missed it, I think you should also email dev@ and users@ saying that you plan on eliminating traffic_sac from v7.0.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---