[jira] [Commented] (STORM-591) logback.xml

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253294#comment-14253294 ] 

ASF GitHub Bot commented on STORM-591:
--------------------------------------

GitHub user Lewuathe opened a pull request:

    https://github.com/apache/storm/pull/352

    [STORM-591] exclude logback.xml from jar

    `logback.xml` should not be included jar file because it will override other configuration who use your jar. 
    To avoid this case exclude `logback.xml` file from storm-core jar file. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Lewuathe/storm exclude-logbackxml

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #352
    
----
commit 4ffb02d80df3e068d34f14b4c625d6e3a696cec7
Author: lewuathe <le...@me.com>
Date:   2014-12-19T11:22:20Z

    [STORM-591] exclude logback.xml from jar

----


> logback.xml
> -----------
>
>                 Key: STORM-591
>                 URL: https://issues.apache.org/jira/browse/STORM-591
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.3
>            Reporter: Shaun Thompson
>
> logback.xml is now being included in storm-core.jar.
> This causes issues for any application that might include storm-core in it's classpath, having to override the config file location.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)