You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/04/04 03:31:57 UTC

Review Request 20023: Removed unreliable setsid test from subprocess_tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20023/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.


Repository: mesos-git


Description
-------

Removed an unreliable test from subprocess_tests as it was expecting a specific order of events without syncing, hence super flaky.


Diffs
-----

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 8d85c05 

Diff: https://reviews.apache.org/r/20023/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 20023: Removed unreliable setsid test from subprocess_tests

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20023/#review39500
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On April 4, 2014, 1:31 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20023/
> -----------------------------------------------------------
> 
> (Updated April 4, 2014, 1:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Removed an unreliable test from subprocess_tests as it was expecting a specific order of events without syncing, hence super flaky.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 8d85c05 
> 
> Diff: https://reviews.apache.org/r/20023/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>