You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/04/24 23:37:41 UTC

Review Request: Fixed bug creating SVN tag in release.sh.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10767/
-----------------------------------------------------------

Review request for mesos, Chris Mattmann, Vinod Kone, and Ben Mahler.


Description
-------

See summary.


Diffs
-----

  support/release.sh ab37027817a52dc9949e15f1a47c5c8401c3b73c 

Diff: https://reviews.apache.org/r/10767/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request: Fixed bug creating SVN tag in release.sh.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On April 26, 2013, 2:58 a.m., Chris Mattmann wrote:
> > support/release.sh, line 63
> > <https://reviews.apache.org/r/10767/diff/1/?file=284232#file284232line63>
> >
> >     Hey Ben, why do we need to run Git at all since 0.11.0 is still in SVN right? And then we have a Mesos mirror, right? So it's automatically mirrored out to Github. Or am I missing something?

This script was written for use within a "git svn" checkout of the SVN repository. Most of us don't even have an SVN checkout of the repository but just do everything from within our "git svn" checkout.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10767/#review19750
-----------------------------------------------------------


On April 24, 2013, 9:37 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10767/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 9:37 p.m.)
> 
> 
> Review request for mesos, Chris Mattmann, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/release.sh ab37027817a52dc9949e15f1a47c5c8401c3b73c 
> 
> Diff: https://reviews.apache.org/r/10767/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Fixed bug creating SVN tag in release.sh.

Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10767/#review19750
-----------------------------------------------------------



support/release.sh
<https://reviews.apache.org/r/10767/#comment40755>

    Hey Ben, why do we need to run Git at all since 0.11.0 is still in SVN right? And then we have a Mesos mirror, right? So it's automatically mirrored out to Github. Or am I missing something?


- Chris Mattmann


On April 24, 2013, 9:37 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10767/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 9:37 p.m.)
> 
> 
> Review request for mesos, Chris Mattmann, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/release.sh ab37027817a52dc9949e15f1a47c5c8401c3b73c 
> 
> Diff: https://reviews.apache.org/r/10767/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Fixed bug creating SVN tag in release.sh.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10767/#review19672
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On April 24, 2013, 9:37 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10767/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 9:37 p.m.)
> 
> 
> Review request for mesos, Chris Mattmann, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/release.sh ab37027817a52dc9949e15f1a47c5c8401c3b73c 
> 
> Diff: https://reviews.apache.org/r/10767/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Fixed bug creating SVN tag in release.sh.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10767/#review19669
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On April 24, 2013, 9:37 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10767/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 9:37 p.m.)
> 
> 
> Review request for mesos, Chris Mattmann, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/release.sh ab37027817a52dc9949e15f1a47c5c8401c3b73c 
> 
> Diff: https://reviews.apache.org/r/10767/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>