[GitHub] [drill] agozhiy commented on issue #1845: DRILL-7353: Wrong driver class is written to the java.sql.Driver

[GitBox <gi...@apache.org>]

agozhiy commented on issue #1845: DRILL-7353: Wrong driver class is written to the java.sql.Driver
URL: https://github.com/apache/drill/pull/1845#issuecomment-523029588
 
 
   @arina-ielchiieva, There are two artifacts that provide java.sql.Driver to the jar. Apparently the wrong one overwrites the right. So I excluded the file from Avatica to resolve the conflict.
   Initially I tried to combine the files into one so both Avatica and Drill jdbc drivers were contained in java.sql.Driver. But as Avatica driver itself is not present in the final jar, error occurred during initialization and so no drivers were registered automatically at all. It can be fixed if swap driver names in java.sql.Driver, but this is unacceptable.
   The best solution would be to include the file from a specific artifact and exclude all the others but I couldn't find a way to do so. But I agree that the current approach is not safe. I'll need to look into it a bit more.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services