You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Abhishek Kumar <la...@gmail.com> on 2017/02/16 14:19:34 UTC
Review Request 56756: Hive View 2.0: Visual Explain-The operators are
being shown out of order
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56756/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20048
https://issues.apache.org/jira/browse/AMBARI-20048
Repository: ambari
Description
-------
The operators are being shown out of order. It\u2019s hard to think about what to do with the plan output when the operators are out of order, so this needs to be fixed first.
Diffs
-----
.gitignore a40e61a
contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 6805bb8
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 2b59340
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js PRE-CREATION
Diff: https://reviews.apache.org/r/56756/diff/
Testing
-------
Manually Tested
Thanks,
Abhishek Kumar
Re: Review Request 56756: Hive View 2.0: Visual Explain-The operators
are being shown out of order
Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56756/
-----------------------------------------------------------
(Updated Feb. 20, 2017, 10:04 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Changes
-------
fixed overlaps and merge
Bugs: AMBARI-20048
https://issues.apache.org/jira/browse/AMBARI-20048
Repository: ambari
Description
-------
The operators are being shown out of order. It\u2019s hard to think about what to do with the plan output when the operators are out of order, so this needs to be fixed first.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 6805bb8
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 2b59340
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer-force.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/bower.json 9fa7076
contrib/views/hive20/src/main/resources/ui/ember-cli-build.js d53cdac
Diff: https://reviews.apache.org/r/56756/diff/
Testing
-------
Manually Tested
Thanks,
Abhishek Kumar
Re: Review Request 56756: Hive View 2.0: Visual Explain-The operators
are being shown out of order
Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56756/
-----------------------------------------------------------
(Updated Feb. 17, 2017, 7:37 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Changes
-------
fixed issue
Bugs: AMBARI-20048
https://issues.apache.org/jira/browse/AMBARI-20048
Repository: ambari
Description
-------
The operators are being shown out of order. It\u2019s hard to think about what to do with the plan output when the operators are out of order, so this needs to be fixed first.
Diffs (updated)
-----
.gitignore a40e61a
contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 6805bb8
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 2b59340
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer-force.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/bower.json 9fa7076
contrib/views/hive20/src/main/resources/ui/ember-cli-build.js d53cdac
Diff: https://reviews.apache.org/r/56756/diff/
Testing
-------
Manually Tested
Thanks,
Abhishek Kumar
Re: Review Request 56756: Hive View 2.0: Visual Explain-The operators
are being shown out of order
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56756/#review165849
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Feb. 16, 2017, 2:19 p.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56756/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 2:19 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20048
> https://issues.apache.org/jira/browse/AMBARI-20048
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The operators are being shown out of order. It\u2019s hard to think about what to do with the plan output when the operators are out of order, so this needs to be fixed first.
>
>
> Diffs
> -----
>
> .gitignore a40e61a
> contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 6805bb8
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 2b59340
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56756/diff/
>
>
> Testing
> -------
>
> Manually Tested
>
>
> Thanks,
>
> Abhishek Kumar
>
>