You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kobayashi Noritada <no...@dolphin.c.u-tokyo.ac.jp> on 2005/10/23 08:23:22 UTC

[PATCH] Remove an unnecessary line from svnshell.rb.

Hi,

I found requiring 'time' not necessary for svnshell.rb.
It is unused not only now but also at the previous revisions in the
Subversion's repository.
Maybe it was used before imported...

Of course it does no harm, but removing it is better than keeping.
Please see this patch.

Thanks,

-nori


  Index: tools/examples/svnshell.rb
  ===================================================================
  --- tools/examples/svnshell.rb	(revision 16925)
  +++ tools/examples/svnshell.rb	(working copy)
  @@ -25,7 +25,6 @@
   
   require "readline"
   require "shellwords"
  -require "time"
   
   require "svn/fs"
   require "svn/core"


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove an unnecessary line from svnshell.rb.

Posted by Kobayashi Noritada <no...@dolphin.c.u-tokyo.ac.jp>.
Hi,

> I found requiring 'time' not necessary for svnshell.rb.
> It is unused not only now but also at the previous revisions in the
> Subversion's repository.
> Maybe it was used before imported...
> 
> Of course it does no harm, but removing it is better than keeping.
> Please see this patch.

I must apologize for attaching no log.

Log:
[[[
* tools/examples/svnshell.rb: Do not require 'time'.
]]]

Thanks,

-nori

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove an unnecessary line from svnshell.rb.

Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,

In <20...@dolphin.c.u-tokyo.ac.jp>
  "[PATCH] Remove an unnecessary line from svnshell.rb." on Sun, 23 Oct 2005 17:23:22 +0900 (JST),
  Kobayashi Noritada <no...@dolphin.c.u-tokyo.ac.jp> wrote:

> I found requiring 'time' not necessary for svnshell.rb.
> It is unused not only now but also at the previous revisions in the
> Subversion's repository.
> Maybe it was used before imported...
> 
> Of course it does no harm, but removing it is better than keeping.
> Please see this patch.

It seems good.
Could you commit the patch, nori?


Thanks,
--
kou

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org