You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/22 17:56:02 UTC
[GitHub] [superset] mistercrunch opened a new pull request, #22197: chore: rename 'Change dataset' action to 'Swap dataset'
mistercrunch opened a new pull request, #22197:
URL: https://github.com/apache/superset/pull/22197
We received feedback around the two options (right above/under one another in a dropdown action list in explore) labeled `Edit dataset` and `Change dataset` are confusing. This PR renames `Change dataset` to `Swap dataset`, which is more clear about the actual action taking place.
We considered other options like: `Switch dataset` or `Point to another dataset` and felt like `Swap dataset` was shorter/clearer.
We also consider re-labeling `Edit dataset` to `Edit dataset properties` but felt it was long and unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22197: chore: rename 'Change dataset' action to 'Swap dataset'
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22197:
URL: https://github.com/apache/superset/pull/22197#issuecomment-1324134489
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22197: chore: rename 'Change dataset' action to 'Swap dataset'
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22197:
URL: https://github.com/apache/superset/pull/22197#issuecomment-1324111464
# [Codecov](https://codecov.io/gh/apache/superset/pull/22197?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22197](https://codecov.io/gh/apache/superset/pull/22197?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cde1586) into [master](https://codecov.io/gh/apache/superset/commit/a77b2d6ebfbe8caf98b2c0d00a19f3f744f18b2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a77b2d6) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22197 +/- ##
=======================================
Coverage 65.49% 65.49%
=======================================
Files 1835 1835
Lines 69927 69927
Branches 7590 7590
=======================================
Hits 45802 45802
Misses 22159 22159
Partials 1966 1966
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.80% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/components/Datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/22197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9DaGFuZ2VEYXRhc291cmNlTW9kYWwudHN4) | `78.68% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/22197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `84.61% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22197: chore: rename 'Change dataset' action to 'Swap dataset'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22197:
URL: https://github.com/apache/superset/pull/22197#issuecomment-1324136230
@lyndsiWilliams Ephemeral environment spinning up at http://35.162.54.145:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22197: chore: rename 'Change dataset' action to 'Swap dataset'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22197:
URL: https://github.com/apache/superset/pull/22197#issuecomment-1325483653
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mistercrunch merged pull request #22197: chore: rename 'Change dataset' action to 'Swap dataset'
Posted by GitBox <gi...@apache.org>.
mistercrunch merged PR #22197:
URL: https://github.com/apache/superset/pull/22197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org