You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/03/04 16:18:11 UTC

Review Request 44391: Added document for overlayfs backend.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44391/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-4866
    https://issues.apache.org/jira/browse/MESOS-4866


Repository: mesos


Description
-------

Added document for overlayfs backend.


Diffs
-----

  docs/mesos-provisioner.md 1b19406cb93bbc3f5330eaf9d29b1be98a674136 

Diff: https://reviews.apache.org/r/44391/diff/


Testing
-------


Thanks,

Guangya Liu


Re: Review Request 44391: Added document for overlayfs backend.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44391/#review122127
-----------------------------------------------------------



Patch looks great!

Reviews applied: [44390, 44391]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 4, 2016, 3:18 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44391/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 3:18 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4866
>     https://issues.apache.org/jira/browse/MESOS-4866
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added document for overlayfs backend.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-provisioner.md 1b19406cb93bbc3f5330eaf9d29b1be98a674136 
> 
> Diff: https://reviews.apache.org/r/44391/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 44391: Added document for overlayfs backend.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44391/#review122222
-----------------------------------------------------------



Patch looks great!

Reviews applied: [44414, 44391]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 6, 2016, 6:57 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44391/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 6:57 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4866 and MESOS-4875
>     https://issues.apache.org/jira/browse/MESOS-4866
>     https://issues.apache.org/jira/browse/MESOS-4875
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added document for overlayfs backend.
> 
> 
> Diffs
> -----
> 
>   docs/container-image.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44391/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 44391: Added document for overlayfs backend.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44391/#review123035
-----------------------------------------------------------


Ship it!





docs/container-image.md (lines 298 - 299)
<https://reviews.apache.org/r/44391/#comment185167>

    This is bad. I don't remember why we have this limitation.


- Jie Yu


On March 6, 2016, 6:57 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44391/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 6:57 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4866 and MESOS-4875
>     https://issues.apache.org/jira/browse/MESOS-4866
>     https://issues.apache.org/jira/browse/MESOS-4875
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added document for overlayfs backend.
> 
> 
> Diffs
> -----
> 
>   docs/container-image.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44391/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 44391: Added document for overlayfs backend.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44391/
-----------------------------------------------------------

(Updated 三月 6, 2016, 6:57 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4866 and MESOS-4875
    https://issues.apache.org/jira/browse/MESOS-4866
    https://issues.apache.org/jira/browse/MESOS-4875


Repository: mesos


Description
-------

Added document for overlayfs backend.


Diffs
-----

  docs/container-image.md PRE-CREATION 

Diff: https://reviews.apache.org/r/44391/diff/


Testing
-------


Thanks,

Guangya Liu


Re: Review Request 44391: Added document for overlayfs backend.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44391/
-----------------------------------------------------------

(Updated 三月 6, 2016, 6:48 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4866
    https://issues.apache.org/jira/browse/MESOS-4866


Repository: mesos


Description
-------

Added document for overlayfs backend.


Diffs (updated)
-----

  docs/container-image.md PRE-CREATION 

Diff: https://reviews.apache.org/r/44391/diff/


Testing
-------


Thanks,

Guangya Liu