You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/09/16 09:42:25 UTC

[GitHub] [kylin] RupengWang commented on a change in pull request #1411: KYLIN-4760 Optimize TopN measure

RupengWang commented on a change in pull request #1411:
URL: https://github.com/apache/kylin/pull/1411#discussion_r489305886



##########
File path: kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/job/CuboidAggregator.scala
##########
@@ -98,9 +98,22 @@ object CuboidAggregator {
             new Column(cdAggregate.toAggregateExpression()).as(id.toString)
           }
         case "TOP_N" =>
-          val schema: StructType = constructTopNSchema(measure.pra)
-          val udfName = UdfManager.register(measure.returnType.toKylinDataType, measure.expression, schema, !reuseLayout)
-          callUDF(udfName, columns: _*).as(id.toString)
+          val schema = StructType(measure.pra.map { col =>

Review comment:
       OK.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org