[GitHub] cjolivier01 commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

[GitBox <gi...@apache.org>]

cjolivier01 commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training
URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176856867
 
 

 ##########
 File path: src/kvstore/kvstore_dist.h
 ##########
 @@ -636,7 +648,7 @@ class KVStoreDist : public KVStoreLocal {
   // Note: this encoding method for row sparse keys doesn't allow cross-layer batching
   inline PSKV& EncodeRowSparseKey(const int key, const int64_t size, const int64_t num_rows,
                                   const int64_t *offsets, const size_t unit_len,
-                                  const int64_t total_num_rows) {
+                                  const int64_t total_num_rows, int num_bytes) {
 
 Review comment:
   throughout, yes pls try to reduce the superfluous computations

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services