You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2009/09/23 05:58:16 UTC
[jira] Created: (MYFACES-2368) Update Render Response Phase to new
spec
Update Render Response Phase to new spec
----------------------------------------
Key: MYFACES-2368
URL: https://issues.apache.org/jira/browse/MYFACES-2368
Project: MyFaces Core
Issue Type: Task
Components: JSR-314
Reporter: Leonardo Uribe
In few words, the new render response phase requires:
- Publish PreRenderViewEvent
- call vdl.buildView() (and remove this call from FaceletsViewDeclarationLanguage.renderResponse)
- deal with org.apache.myfaces.context.servlet.ResponseSwitch (on/off when f:view)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2368) Update Render Response Phase to
new spec
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776181#action_12776181 ]
Leonardo Uribe commented on MYFACES-2368:
-----------------------------------------
Committed a solution for the first two, but there is still pending the last one (on/off when f:view). Also added the following comment:
// TODO: JSF 2.0 section 2.2.6, it says if the current response
// is a partial response(ajax), then there must be no content written
// outside of the f:view. This has sense only on jsp case, because
// we don't control jsp rendering and in this way we prevent unwanted
// rendering. But note f:ajax only works on facelets, and f:view
// tag handler only set properties for the current view root. It's
// more, in facelets, every thing that render is a UIComponent instance,
// so it is inside view root.
// Anyway, we should put the expected behavior (take a look at
// context.servlet.ResponseSwitch) here and enable rendering when
// PartialViewContextImpl.processPartialRendering(UIComponent, PhaseId)
// do its own work, but for now it is
> Update Render Response Phase to new spec
> ----------------------------------------
>
> Key: MYFACES-2368
> URL: https://issues.apache.org/jira/browse/MYFACES-2368
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Reporter: Leonardo Uribe
>
> In few words, the new render response phase requires:
> - Publish PreRenderViewEvent
> - call vdl.buildView() (and remove this call from FaceletsViewDeclarationLanguage.renderResponse)
> - deal with org.apache.myfaces.context.servlet.ResponseSwitch (on/off when f:view)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2368) Update Render Response Phase to new
spec
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr updated MYFACES-2368:
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-alpha-2
Status: Resolved (was: Patch Available)
committed my patch for "deal with org.apache.myfaces.context.servlet.ResponseSwitch (on/off when f:view)". the issue is now complete.
> Update Render Response Phase to new spec
> ----------------------------------------
>
> Key: MYFACES-2368
> URL: https://issues.apache.org/jira/browse/MYFACES-2368
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Reporter: Leonardo Uribe
> Fix For: 2.0.0-alpha-2
>
> Attachments: myfaces-2368.patch
>
>
> In few words, the new render response phase requires:
> - Publish PreRenderViewEvent
> - call vdl.buildView() (and remove this call from FaceletsViewDeclarationLanguage.renderResponse)
> - deal with org.apache.myfaces.context.servlet.ResponseSwitch (on/off when f:view)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2368) Update Render Response Phase to
new spec
Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804523#action_12804523 ]
Mark Struberg commented on MYFACES-2368:
----------------------------------------
Sorry, there seems to be a problem in this area, because I get a NPE now:
{noformat}
java.lang.NullPointerException
at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:47)
at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:201)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:191)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
{noformat}
> Update Render Response Phase to new spec
> ----------------------------------------
>
> Key: MYFACES-2368
> URL: https://issues.apache.org/jira/browse/MYFACES-2368
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Reporter: Leonardo Uribe
> Fix For: 2.0.0-beta
>
> Attachments: myfaces-2368.patch
>
>
> In few words, the new render response phase requires:
> - Publish PreRenderViewEvent
> - call vdl.buildView() (and remove this call from FaceletsViewDeclarationLanguage.renderResponse)
> - deal with org.apache.myfaces.context.servlet.ResponseSwitch (on/off when f:view)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2368) Update Render Response Phase to
new spec
Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804532#action_12804532 ]
Mark Struberg commented on MYFACES-2368:
----------------------------------------
This problem happened with the snapshot currently available on the public snapshot repo but seems to be fixed in SVN already.
Which means this patch is just fine!
> Update Render Response Phase to new spec
> ----------------------------------------
>
> Key: MYFACES-2368
> URL: https://issues.apache.org/jira/browse/MYFACES-2368
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Reporter: Leonardo Uribe
> Fix For: 2.0.0-beta
>
> Attachments: myfaces-2368.patch
>
>
> In few words, the new render response phase requires:
> - Publish PreRenderViewEvent
> - call vdl.buildView() (and remove this call from FaceletsViewDeclarationLanguage.renderResponse)
> - deal with org.apache.myfaces.context.servlet.ResponseSwitch (on/off when f:view)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2368) Update Render Response Phase to
new spec
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798072#action_12798072 ]
Jakob Korherr commented on MYFACES-2368:
----------------------------------------
And to your comment, Leonardo:
It's true that f:ajax only works on facelets, but isn't it possible to use the javascript api also on JSPs?
> Update Render Response Phase to new spec
> ----------------------------------------
>
> Key: MYFACES-2368
> URL: https://issues.apache.org/jira/browse/MYFACES-2368
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Reporter: Leonardo Uribe
> Attachments: myfaces-2368.patch
>
>
> In few words, the new render response phase requires:
> - Publish PreRenderViewEvent
> - call vdl.buildView() (and remove this call from FaceletsViewDeclarationLanguage.renderResponse)
> - deal with org.apache.myfaces.context.servlet.ResponseSwitch (on/off when f:view)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2368) Update Render Response Phase to new
spec
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr updated MYFACES-2368:
-----------------------------------
Status: Patch Available (was: Open)
> Update Render Response Phase to new spec
> ----------------------------------------
>
> Key: MYFACES-2368
> URL: https://issues.apache.org/jira/browse/MYFACES-2368
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Reporter: Leonardo Uribe
> Attachments: myfaces-2368.patch
>
>
> In few words, the new render response phase requires:
> - Publish PreRenderViewEvent
> - call vdl.buildView() (and remove this call from FaceletsViewDeclarationLanguage.renderResponse)
> - deal with org.apache.myfaces.context.servlet.ResponseSwitch (on/off when f:view)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.