You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by "Peter Ansell (JIRA)" <ji...@apache.org> on 2013/02/04 00:18:12 UTC

[jira] [Commented] (ANY23-144) Implement comprehensive naming of o.a.a.api.vocab classes

    [ https://issues.apache.org/jira/browse/ANY23-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569925#comment-13569925 ] 

Peter Ansell commented on ANY23-144:
------------------------------------

The changes seem a little arbitrary, as the acronyms are not generally built as words, although the case of microformats they seem to be in some cases. This results in the patch having Xhtml instead of XHtml, while it has VCalendar, instead of Vcalendar, which doesn't seem to be an intuitive distinction. I suggest that we either convert all of the cases to a single upper case character to start and then lowercase characters to continue, to be consistent, or switch back to entirely upper-casing to match the OpenRDF Sesame Vocabulary classes.

By comparison, the OpenRDF Sesame built-in vocabularies (which we are happy to accept patches for in Sesame), use static final constants which are all uppercased, per the java convention for static final constants. The vocabularies in Any23 are in practice static final constants when they are linked into extractors, so there is no practical difference at that point.
                
> Implement comprehensive naming of o.a.a.api.vocab classes 
> ----------------------------------------------------------
>
>                 Key: ANY23-144
>                 URL: https://issues.apache.org/jira/browse/ANY23-144
>             Project: Apache Any23
>          Issue Type: Improvement
>          Components: api
>    Affects Versions: 0.7.0
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: ANY23-144.patch
>
>
> As Simo pointed out we currently have a rather naff naming convention for all classes contained within the above package.
> This issue should address that and rename all classes.
> Thread for reference 
> http://s.apache.org/XTk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira