You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by sanju1010 <gi...@git.apache.org> on 2015/07/30 13:11:06 UTC

[GitHub] cloudstack pull request: Removed "medium" dictionary from test_dat...

GitHub user sanju1010 opened a pull request:

    https://github.com/apache/cloudstack/pull/644

    Removed "medium" dictionary from test_data and modified the tests dependen on it

    We have two entried(keys) named "small" and "medium" inside test_data.py to specify the vm properties and access details. However, both contain the same values. So deleted one of them and also modified the tests accordingly.
    
    Ran all the tests and all of them passed.
    
    Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
    ok
    Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
    ok
    Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
    ok
    Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
    ok
    Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
    ok
    Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
    ok
    Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
    ok
    Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
    ok
    Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
    
    Test to create service offering ... === TestName: test_01_create_service_offering | Status : SUCCESS ===
    ok
    Test to update existing service offering ... === TestName: test_02_edit_service_offering | Status : SUCCESS ===
    ok
    Test to delete service offering ... === TestName: test_03_delete_service_offering | Status : SUCCESS ===
    ok
    Test to change service to a small capacity ... === TestName: test_04_change_offering_small | Status : SUCCESS ===
    ok
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanju1010/cloudstack testdata

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #644
    
----
commit 340e23c2d7dc595856d9c62d493272b91fc13a28
Author: sanjeev <sa...@apache.org>
Date:   2015-07-08T06:19:17Z

    Removed medium dictionary from test_data and modified the tests dependent on it
    Bug-Id: CLOUDSTACK-8617
    
    Removed commented lines from the files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed "medium" dictionary from test_dat...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/644


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed "medium" dictionary from test_dat...

Posted by nitt10prashant <gi...@git.apache.org>.

Github user nitt10prashant commented on the pull request:

    https://github.com/apache/cloudstack/pull/644#issuecomment-127186217
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed "medium" dictionary from test_dat...

Posted by jayapalu <gi...@git.apache.org>.

Github user jayapalu commented on the pull request:

    https://github.com/apache/cloudstack/pull/644#issuecomment-128249920
  
    All the tests success results are given in the PR.
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---