You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/09/10 19:44:41 UTC
[GitHub] [accumulo] jkosh44 opened a new pull request #1703: Deprecate Master and replace with Manager in public API
jkosh44 opened a new pull request #1703:
URL: https://github.com/apache/accumulo/pull/1703
Fixes #1643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jkosh44 commented on pull request #1703: Deprecate Master and replace with Manager in public API
Posted by GitBox <gi...@apache.org>.
jkosh44 commented on pull request #1703:
URL: https://github.com/apache/accumulo/pull/1703#issuecomment-803317434
@ctubbsii so sorry that I never responded to the comments, my github notifications have been messed up and I never saw these. For what it's worth the changes look fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1703: Deprecate Master and replace with Manager in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1703:
URL: https://github.com/apache/accumulo/pull/1703#issuecomment-690841930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1703: Deprecate Master and replace with Manager in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1703:
URL: https://github.com/apache/accumulo/pull/1703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1703: Deprecate Master and replace with Manager in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1703:
URL: https://github.com/apache/accumulo/pull/1703#issuecomment-690851241
@jkosh44 Please see #1704. I wouldn't mind having your review on that, if you have a chance to look, since it rolls back the changes you made (and I merged) here to `Instance`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1703: Deprecate Master and replace with Manager in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1703:
URL: https://github.com/apache/accumulo/pull/1703#issuecomment-690841930
@jkosh44 It occurred to me after I merged that it probably wasn't necessary to modify `Instance`, since that is already deprecated and ready to be removed in 3.0.0... the same time these newly deprecated methods would be removed. So, the deprecation cycle for `Instance` was already on track. I will do a partial revert of those changes, so as to limit the introduction of a new API in 2.1.0 in an already deprecated class, that can be removed in 3.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jkosh44 commented on pull request #1703: Deprecate Master and replace with Manager in public API
Posted by GitBox <gi...@apache.org>.
jkosh44 commented on pull request #1703:
URL: https://github.com/apache/accumulo/pull/1703#issuecomment-690759487
> Looks great overall.
>
> Please add `@SuppressWarnings("removal")` on the methods causing compiler warnings because of the use of the `MASTER` enum.
Pretty sure I got all of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1703: Deprecate Master and replace with Manager in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1703:
URL: https://github.com/apache/accumulo/pull/1703#issuecomment-690851241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1703: Deprecate Master and replace with Manager in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1703:
URL: https://github.com/apache/accumulo/pull/1703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jkosh44 commented on pull request #1703: Deprecate Master and replace with Manager in public API
Posted by GitBox <gi...@apache.org>.
jkosh44 commented on pull request #1703:
URL: https://github.com/apache/accumulo/pull/1703#issuecomment-690780895
Looks like the failed check is from a connection timeout download hadoop jars from maven. Can we re-run it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org