You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/12/02 21:44:07 UTC

Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40880/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till Toenshoff.


Bugs: MESOS-4047
    https://issues.apache.org/jira/browse/MESOS-4047


Repository: mesos


Description
-------

`MesosContainerizerSlaveRecoveryTest.ResourceStatistics` has very similar logic for restarting an agent, re-registering the executor, and even getting `ResourceStatistics`.  But `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is stable.

This patch updates the flaky test's wait-for-agent-recovery logic to match the stable test.


Diffs
-----

  src/tests/containerizer/memory_pressure_tests.cpp e18b971c4df26c9b9c103ca73bdad4fd400d6c02 

Diff: https://reviews.apache.org/r/40880/diff/


Testing
-------

On Ubuntu 14:
`make check`
`sudo bin/mesos-tests.sh --gtest_filter="*MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery*" --gtest_repeat=-1 --gtest_break_on_failure`

^ Ran the above until satisfied.


Thanks,

Joseph Wu


Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40880/#review108830
-----------------------------------------------------------

Ship it!


Ship It!

- Bernd Mathiske


On Dec. 2, 2015, 12:44 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40880/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 12:44 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4047
>     https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` has very similar logic for restarting an agent, re-registering the executor, and even getting `ResourceStatistics`.  But `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is stable.
> 
> This patch updates the flaky test's wait-for-agent-recovery logic to match the stable test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_pressure_tests.cpp e18b971c4df26c9b9c103ca73bdad4fd400d6c02 
> 
> Diff: https://reviews.apache.org/r/40880/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 14:
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery*" --gtest_repeat=-1 --gtest_break_on_failure`
> 
> ^ Ran the above until satisfied.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40880/#review108733
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40849, 40880]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 2, 2015, 8:44 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40880/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 8:44 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4047
>     https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` has very similar logic for restarting an agent, re-registering the executor, and even getting `ResourceStatistics`.  But `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is stable.
> 
> This patch updates the flaky test's wait-for-agent-recovery logic to match the stable test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_pressure_tests.cpp e18b971c4df26c9b9c103ca73bdad4fd400d6c02 
> 
> Diff: https://reviews.apache.org/r/40880/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 14:
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery*" --gtest_repeat=-1 --gtest_break_on_failure`
> 
> ^ Ran the above until satisfied.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40880/#review111171
-----------------------------------------------------------

Ship it!


Ship It!

- Joerg Schad


On Dec. 3, 2015, 7:02 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40880/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4047
>     https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` has very similar logic for restarting an agent, re-registering the executor, and even getting `ResourceStatistics`.  But `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is stable.
> 
> This patch updates the flaky test's wait-for-agent-recovery logic to match the stable test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_pressure_tests.cpp e18b971c4df26c9b9c103ca73bdad4fd400d6c02 
> 
> Diff: https://reviews.apache.org/r/40880/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 14:
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery*" --gtest_repeat=-1 --gtest_break_on_failure`
> 
> ^ Ran the above until satisfied.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40880/#review108873
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40849, 40880]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 3, 2015, 7:02 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40880/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4047
>     https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` has very similar logic for restarting an agent, re-registering the executor, and even getting `ResourceStatistics`.  But `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is stable.
> 
> This patch updates the flaky test's wait-for-agent-recovery logic to match the stable test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_pressure_tests.cpp e18b971c4df26c9b9c103ca73bdad4fd400d6c02 
> 
> Diff: https://reviews.apache.org/r/40880/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 14:
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery*" --gtest_repeat=-1 --gtest_break_on_failure`
> 
> ^ Ran the above until satisfied.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40880/#review111170
-----------------------------------------------------------

Ship it!


Looks good to me. Testing something on the containerizer sounds more accurate than waiting for the slave reregistered ack to be received from the master, since we're really focused on the executor reregistering with the slave rather than the slave with the master.

- Adam B


On Dec. 3, 2015, 11:02 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40880/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4047
>     https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` has very similar logic for restarting an agent, re-registering the executor, and even getting `ResourceStatistics`.  But `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is stable.
> 
> This patch updates the flaky test's wait-for-agent-recovery logic to match the stable test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_pressure_tests.cpp e18b971c4df26c9b9c103ca73bdad4fd400d6c02 
> 
> Diff: https://reviews.apache.org/r/40880/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 14:
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery*" --gtest_repeat=-1 --gtest_break_on_failure`
> 
> ^ Ran the above until satisfied.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40880/
-----------------------------------------------------------

(Updated Dec. 3, 2015, 11:02 a.m.)


Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till Toenshoff.


Changes
-------

Rebase!


Bugs: MESOS-4047
    https://issues.apache.org/jira/browse/MESOS-4047


Repository: mesos


Description
-------

`MesosContainerizerSlaveRecoveryTest.ResourceStatistics` has very similar logic for restarting an agent, re-registering the executor, and even getting `ResourceStatistics`.  But `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is stable.

This patch updates the flaky test's wait-for-agent-recovery logic to match the stable test.


Diffs (updated)
-----

  src/tests/containerizer/memory_pressure_tests.cpp e18b971c4df26c9b9c103ca73bdad4fd400d6c02 

Diff: https://reviews.apache.org/r/40880/diff/


Testing
-------

On Ubuntu 14:
`make check`
`sudo bin/mesos-tests.sh --gtest_filter="*MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery*" --gtest_repeat=-1 --gtest_break_on_failure`

^ Ran the above until satisfied.


Thanks,

Joseph Wu