You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Larry Li (JIRA)" <ji...@apache.org> on 2018/01/19 20:41:00 UTC

[jira] [Created] (BEAM-3502) Avoid use of proto.Builder.clone() in DatastoreIO

Larry Li created BEAM-3502:
------------------------------

             Summary: Avoid use of proto.Builder.clone() in DatastoreIO
                 Key: BEAM-3502
                 URL: https://issues.apache.org/jira/browse/BEAM-3502
             Project: Beam
          Issue Type: Improvement
          Components: beam-model
    Affects Versions: 2.2.0
            Reporter: Larry Li
            Assignee: Kenneth Knowles
             Fix For: 2.3.0


DatastoreIO uses proto.Builder.clone() here:

[https://github.com/apache/beam/blob/c0f0e1fd63ce1e9dfe1db71adf1c8b9e88ce7038/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java#L893]

 

It's only used in one place for actual runtime code, but this causes incompatibility problems with Google-internal Java proto generation, i.e. we get a 'NoSuchMethodError' when attempting to run the pipeline with internal build tools.

 

This is a known problem that's already been worked around once:

https://issues.apache.org/jira/browse/BEAM-2392

..but the fix only applied to BigtableServiceImpl. This extends those changes to DatastoreIO, replacing its single use of clone(). Associated tests shouldn't need refactoring, as this only appears as a problem at runtime.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)