You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2021/12/06 21:50:15 UTC

[superset] 04/05: use full resultType with csv download on chart in dashboard (#17431)

This is an automated email from the ASF dual-hosted git repository.

elizabeth pushed a commit to branch 1.4
in repository https://gitbox.apache.org/repos/asf/superset.git

commit c42ff7972f8879f83de807a411b3e5f84bab3d75
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Mon Nov 15 09:57:05 2021 -0800

    use full resultType with csv download on chart in dashboard (#17431)
    
    (cherry picked from commit 71e3fa1bf350045da9a1c1e89443549c204a3516)
---
 .../spec/javascripts/dashboard/components/gridComponents/Chart_spec.jsx | 2 +-
 superset-frontend/src/dashboard/components/gridComponents/Chart.jsx     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/spec/javascripts/dashboard/components/gridComponents/Chart_spec.jsx b/superset-frontend/spec/javascripts/dashboard/components/gridComponents/Chart_spec.jsx
index fdbd766..b2acc42 100644
--- a/superset-frontend/spec/javascripts/dashboard/components/gridComponents/Chart_spec.jsx
+++ b/superset-frontend/spec/javascripts/dashboard/components/gridComponents/Chart_spec.jsx
@@ -116,7 +116,7 @@ describe('Chart', () => {
     expect(stubbedExportCSV.lastCall.args[0]).toEqual(
       expect.objectContaining({
         formData: expect.anything(),
-        resultType: 'results',
+        resultType: 'full',
         resultFormat: 'csv',
       }),
     );
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx b/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
index 4a86d89..3447c98 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
@@ -242,7 +242,7 @@ export default class Chart extends React.Component {
       formData: isFullCSV
         ? { ...this.props.formData, row_limit: this.props.maxRows }
         : this.props.formData,
-      resultType: 'results',
+      resultType: 'full',
       resultFormat: 'csv',
     });
   }