[jira] [Commented] (LUCENE-9219) Port ECJ-based linter to gradle

["Tomoko Uchida (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039190#comment-17039190 ] 

Tomoko Uchida commented on LUCENE-9219:
---------------------------------------

Hi [~dweiss],

I attached [^LUCENE-9219.patch], a modified version of the patch in LUCENE-9201. Could you take a look at this?
 (diffs from LUCENE-9201-ecj-2.patch)
 - use sourceSet.getTaskName()
 - task group was changed to "Verification"
 - the artifact version of "org.eclipse.jdt:ecj" was moved to "build.gradle" from "ecj-lint.gradle"

Also I excluded the changes for "lucene/common-build.xml", because I thought this was added to the patch accidentally. Please let me know if this should be included again.
{code:java}
diff --git a/lucene/common-build.xml b/lucene/common-build.xml
index 1e3da88250b..ca5887df550 100644
--- a/lucene/common-build.xml
+++ b/lucene/common-build.xml
@@ -2034,6 +2034,7 @@ ${ant.project.name}.test.dependencies=${test.classpath.list}
   </target>
 
   <target name="-ecj-javadoc-lint" depends="-ecj-javadoc-lint-unsupported,-ecj-javadoc-lint-src,-ecj-javadoc-lint-tests"/>
+  <target name="ecj" depends="-ecj-javadoc-lint" />
{code}

> Port ECJ-based linter to gradle
> -------------------------------
>
>                 Key: LUCENE-9219
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9219
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Dawid Weiss
>            Priority: Major
>         Attachments: LUCENE-9219.patch, LUCENE-9219.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org