[jira] [Reopened] (LUCENE-5936) Add BWC checks to verify what is tested matches what versions we know about

["Uwe Schindler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler reopened LUCENE-5936:
-----------------------------------

The "special detection" of Lucene is trunk in the new branch_5x is not working, because minor and bugfix version == 0.

For now I disabled this fragment only in branch_5x, its still there in trunk:

{code:java}
    if (Version.LATEST.minor == 0 && Version.LATEST.bugfix == 0 && Version.LATEST.prerelease == 0) {
      // we are on trunk (latest is a first major release) so the last minor index
      // for the previous major version is also not yet tested
      assertNotNull(lastPrevMajorVersion);
      expectedVersions.remove(lastPrevMinorIndex);
    }
{code}

My proposal: Add a boolean at the beginning of TestBackwords test thats named: boolean isLuceneTrunk = true/false

This is easier to maintain, it will be true in Lucene trunk only, false otherwise.

> Add BWC checks to verify what is tested matches what versions we know about
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-5936
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5936
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Ryan Ernst
>            Assignee: Ryan Ernst
>             Fix For: 4.10.1, 5.0, 6.0
>
>         Attachments: LUCENE-5936.patch, LUCENE-5936.patch
>
>
> This is a follow up from LUCENE-5934.  Mike has already has something like this for the smoke tester, but here I am suggesting a test within the test (similar to other Version tests we have which check things like deprecation status of old versions).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org