[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

[GitBox <gi...@apache.org>]

murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686129516


   @sigram @noblepaul I have removed the `PropertyValue` concept. Now once `PropertyKeys` are fetched, the value is accessed directly on the key (no more returned map). This simplifies plugin code and removes `instanceof` and cast operations related to keys in the plugins.
   
   I started (just started) work on the more realistic plugin `SamplePluginAffinityReplicaPlacement` (did describe in the Javadoc how I intend to approach it), and as I see which methods I need there, I'm updating the API with anything that would likely make sense for anybody writing another plugin.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org