You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2025/02/20 05:31:01 UTC

[kudu-CR](branch-1.18.x) [consensus] address warning on released replicates

Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22507


Change subject: [consensus] address warning on released replicates
......................................................................

[consensus] address warning on released replicates

This patch addresses a warning that appeared after upgrading protobuf
to version 3.21.9.  Since the new protobuf marks some of the
auto-generated methods with the [[nodiscard]] attribute, there was an
extra warning that might have pointed to a possible memory leak.
It wasn't the case because of the Log::AsyncAppendReplicates() method's
semantics, but it's worth addressing it anyway.

Change-Id: Ia756597b920622baef8c55b5040d6c051814db63
Reviewed-on: http://gerrit.cloudera.org:8080/22505
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 57fb36a72261e1369dd9e5bc222676a0b860525e)
---
M src/kudu/consensus/log.cc
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/22507/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia756597b920622baef8c55b5040d6c051814db63
Gerrit-Change-Number: 22507
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.18.x) [consensus] address warning on released replicates

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22507 )

Change subject: [consensus] address warning on released replicates
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1094/


-- 
To view, visit http://gerrit.cloudera.org:8080/22507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia756597b920622baef8c55b5040d6c051814db63
Gerrit-Change-Number: 22507
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2025 05:31:09 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [consensus] address warning on released replicates

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22507 )

Change subject: [consensus] address warning on released replicates
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1094/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia756597b920622baef8c55b5040d6c051814db63
Gerrit-Change-Number: 22507
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2025 06:43:37 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [consensus] address warning on released replicates

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [consensus] address warning on released replicates
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia756597b920622baef8c55b5040d6c051814db63
Gerrit-Change-Number: 22507
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) [consensus] address warning on released replicates

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22507 )

Change subject: [consensus] address warning on released replicates
......................................................................


Patch Set 1: Verified+1

unrelated test failure (DEBUG): TabletServerTest.TestTimeBasedFlushDMS


-- 
To view, visit http://gerrit.cloudera.org:8080/22507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia756597b920622baef8c55b5040d6c051814db63
Gerrit-Change-Number: 22507
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 21 Feb 2025 01:10:39 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [consensus] address warning on released replicates

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22507 )

Change subject: [consensus] address warning on released replicates
......................................................................

[consensus] address warning on released replicates

This patch addresses a warning that appeared after upgrading protobuf
to version 3.21.9.  Since the new protobuf marks some of the
auto-generated methods with the [[nodiscard]] attribute, there was an
extra warning that might have pointed to a possible memory leak.
It wasn't the case because of the Log::AsyncAppendReplicates() method's
semantics, but it's worth addressing it anyway.

Change-Id: Ia756597b920622baef8c55b5040d6c051814db63
Reviewed-on: http://gerrit.cloudera.org:8080/22505
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 57fb36a72261e1369dd9e5bc222676a0b860525e)
Reviewed-on: http://gerrit.cloudera.org:8080/22507
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/consensus/log.cc
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia756597b920622baef8c55b5040d6c051814db63
Gerrit-Change-Number: 22507
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) [consensus] address warning on released replicates

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22507 )

Change subject: [consensus] address warning on released replicates
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia756597b920622baef8c55b5040d6c051814db63
Gerrit-Change-Number: 22507
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2025 06:26:31 +0000
Gerrit-HasComments: No