You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@cn.ibm.com> on 2016/11/30 09:56:02 UTC
Review Request 54198: Added Resource.Allocation in Offer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54198/
-----------------------------------------------------------
Review request for mesos, Guangya Liu and Qian Zhang.
Bugs: MESOS-6634
https://issues.apache.org/jira/browse/MESOS-6634
Repository: mesos
Description
-------
Added Resource.Allocation in Offer protobuf message to indicate a
single role per offer. To preserve the offer semantics between a
single multi-role scheduler and multiple single-role schedulers,
we would like to ensure that an offer only contains resources
allocated to a single role.
Diffs
-----
include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05
include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13
Diff: https://reviews.apache.org/r/54198/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 54198: Added Resource.Allocation in Offer.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54198/#review157883
-----------------------------------------------------------
Ship it!
include/mesos/mesos.proto (lines 1325 - 1329)
<https://reviews.apache.org/r/54198/#comment228507>
Let's add the same note to these as we did with the AllocationInfo inside Resource:
```
// NOTE: Implementation of this is in-progress, DO NOT USE!
```
- Benjamin Mahler
On Dec. 2, 2016, 8:48 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54198/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2016, 8:48 a.m.)
>
>
> Review request for mesos, Guangya Liu and Qian Zhang.
>
>
> Bugs: MESOS-6634
> https://issues.apache.org/jira/browse/MESOS-6634
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Resource.Allocation in Offer protobuf message to indicate a
> single role per offer. To preserve the offer semantics between a
> single multi-role scheduler and multiple single-role schedulers,
> we would like to ensure that an offer only contains resources
> allocated to a single role.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5981cb8357dc9ead141402aed82db81f8004b2cd
> include/mesos/v1/mesos.proto a560ed336c7fe4a745df11d3a6d753d5ff1d9b9c
>
> Diff: https://reviews.apache.org/r/54198/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54198: Added Resource.Allocation in Offer.
Posted by Jay Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54198/
-----------------------------------------------------------
(Updated Dec. 2, 2016, 8:48 a.m.)
Review request for mesos, Guangya Liu and Qian Zhang.
Bugs: MESOS-6634
https://issues.apache.org/jira/browse/MESOS-6634
Repository: mesos
Description
-------
Added Resource.Allocation in Offer protobuf message to indicate a
single role per offer. To preserve the offer semantics between a
single multi-role scheduler and multiple single-role schedulers,
we would like to ensure that an offer only contains resources
allocated to a single role.
Diffs (updated)
-----
include/mesos/mesos.proto 5981cb8357dc9ead141402aed82db81f8004b2cd
include/mesos/v1/mesos.proto a560ed336c7fe4a745df11d3a6d753d5ff1d9b9c
Diff: https://reviews.apache.org/r/54198/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 54198: Added Resource.Allocation in Offer.
Posted by Jay Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54198/
-----------------------------------------------------------
(Updated Dec. 1, 2016, 2:47 a.m.)
Review request for mesos, Guangya Liu and Qian Zhang.
Changes
-------
addressed guangya's comment
Bugs: MESOS-6634
https://issues.apache.org/jira/browse/MESOS-6634
Repository: mesos
Description
-------
Added Resource.Allocation in Offer protobuf message to indicate a
single role per offer. To preserve the offer semantics between a
single multi-role scheduler and multiple single-role schedulers,
we would like to ensure that an offer only contains resources
allocated to a single role.
Diffs (updated)
-----
include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05
include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13
Diff: https://reviews.apache.org/r/54198/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 54198: Added Resource.Allocation in Offer.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54198/#review157520
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
include/mesos/mesos.proto (line 1313)
<https://reviews.apache.org/r/54198/#comment228144>
s/represent/represents
- Guangya Liu
On \u5341\u4e00\u6708 30, 2016, 9:56 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54198/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e00\u6708 30, 2016, 9:56 a.m.)
>
>
> Review request for mesos, Guangya Liu and Qian Zhang.
>
>
> Bugs: MESOS-6634
> https://issues.apache.org/jira/browse/MESOS-6634
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Resource.Allocation in Offer protobuf message to indicate a
> single role per offer. To preserve the offer semantics between a
> single multi-role scheduler and multiple single-role schedulers,
> we would like to ensure that an offer only contains resources
> allocated to a single role.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05
> include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13
>
> Diff: https://reviews.apache.org/r/54198/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>