You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/10/13 18:20:32 UTC
Review Request 39277: Improve update repo custom action
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39277/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
Bugs: AMBARI-13405
https://issues.apache.org/jira/browse/AMBARI-13405
Repository: ambari
Description
-------
We need the ability to continue executing commands even if some calls fail (again, I think install package has the ability)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/Role.java c684981
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 564a288
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java eed4379
Diff: https://reviews.apache.org/r/39277/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 39277: Improve update repo custom action
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Oct. 13, 2015, 6:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java, line 442
> > <https://reviews.apache.org/r/39277/diff/1/?file=1097465#file1097465line442>
> >
> > Do we need to document this property?
> > Or set it in ambari.properties
> >
> > I would expect it to be a percentage.
This property already exists in Stage class. We don't need to set it in ambari.properties, because we can pass it during custom action call for update_repo action. One more, we are using this property on ly for update_repo action, so no need to add it to ambari.properties. Success factor has default value, so user should pass it only is some critical moments.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39277/#review102483
-----------------------------------------------------------
On Oct. 13, 2015, 4:20 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39277/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 4:20 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-13405
> https://issues.apache.org/jira/browse/AMBARI-13405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need the ability to continue executing commands even if some calls fail (again, I think install package has the ability)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/Role.java c684981
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 564a288
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java eed4379
>
> Diff: https://reviews.apache.org/r/39277/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 39277: Improve update repo custom action
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39277/#review102483
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java (line 440)
<https://reviews.apache.org/r/39277/#comment160167>
Do we need to document this property?
Or set it in ambari.properties
I would expect it to be a percentage.
- Alejandro Fernandez
On Oct. 13, 2015, 4:20 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39277/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 4:20 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-13405
> https://issues.apache.org/jira/browse/AMBARI-13405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need the ability to continue executing commands even if some calls fail (again, I think install package has the ability)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/Role.java c684981
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 564a288
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java eed4379
>
> Diff: https://reviews.apache.org/r/39277/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 39277: Improve update repo custom action
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39277/#review102668
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java (line 436)
<https://reviews.apache.org/r/39277/#comment160421>
Can you add some doc to this function?
- Alejandro Fernandez
On Oct. 13, 2015, 4:20 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39277/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 4:20 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-13405
> https://issues.apache.org/jira/browse/AMBARI-13405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need the ability to continue executing commands even if some calls fail (again, I think install package has the ability)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/Role.java c684981
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 564a288
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java eed4379
>
> Diff: https://reviews.apache.org/r/39277/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 39277: Improve update repo custom action
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39277/#review102713
-----------------------------------------------------------
Ship it!
+1 to Alejandro's comment.
- Sumit Mohanty
On Oct. 13, 2015, 4:20 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39277/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 4:20 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-13405
> https://issues.apache.org/jira/browse/AMBARI-13405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need the ability to continue executing commands even if some calls fail (again, I think install package has the ability)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/Role.java c684981
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 564a288
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java eed4379
>
> Diff: https://reviews.apache.org/r/39277/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>