You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/17 22:01:16 UTC

[GitHub] [tvm] Icemist commented on a diff in pull request #13420: [RPC] Fix tracker connection termination

Icemist commented on code in PR #13420:
URL: https://github.com/apache/tvm/pull/13420#discussion_r1025776485


##########
tests/python/unittest/test_runtime_rpc.py:
##########
@@ -448,10 +448,10 @@ def check_remote():
 
 
 @tvm.testing.requires_rpc
-def test_rpc_tracker_register():
+@pytest.mark.parametrize("device_key", ["test_device", "127.0.0.1:5555"])

Review Comment:
   I'm not sure. I want to fix exactly the current case. 
   The issue in that case is in format of key `hexagon-dev.192.168.0.143:5555:0.513619`.
   
   Before the fix this test was falling with "127.0.0.1:5555", after it works 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org