You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/06/03 16:48:25 UTC
[GitHub] incubator-zeppelin pull request #956: [ZEPPELIN-923] Apply new mechanism to ...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/956
[ZEPPELIN-923] Apply new mechanism to ShellInterpreter
### What is this PR for?
This PR applies the new interpreter registration mechanism to Shell interpreter.
### What type of PR is it?
Improvement
### Todos
* [x] - Remove static property definition code lines in `shellInterpreter.java` and add `interpreter-setting.json` under the `shell/src/main/resources`
### What is the Jira issue?
[ZEPPELIN-923](https://issues.apache.org/jira/browse/ZEPPELIN-923)
### How should this be tested?
1. apply patch
2. rm -r `interpreter/sh` and `conf/interpreter.json`
3. build source
4. bin/zeppelin-daemon.sh start
5. Run some shell command
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-923
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/956.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #956
----
commit e312f5a88a7c5b082a37f56215ea92df469f4403
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-03T16:16:20Z
ZEPPELIN-923: Apply new interpreter mechanism to Shell interpreter
commit f6a693356b34d1ff101dff779dafe135920def1a
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-03T16:18:51Z
ZEPPELIN-923: Change defaultValue 5000 -> 60000
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #956: [ZEPPELIN-923] Apply new mechanism to ShellIn...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
\U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #956: [ZEPPELIN-923] Apply new mechanism to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/956
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #956: [ZEPPELIN-923] Apply new mechanism to ShellIn...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
Merging this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #956: [ZEPPELIN-923] Apply new mechanism to ShellIn...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
@jongyoul But CI is failed :( Is this relevant with this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #956: [ZEPPELIN-923] Apply new mechanism to ShellIn...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
@AhyoungRyu have made a fix #4492.7 failed #958. Can you rebase with master, and re-trigger ?
And yes other is `[INFO] Rat check: Summary of files. Unapproved: 1 unknown: 1 generated: 0 approved: 2 licence.`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #956: [ZEPPELIN-923] Apply new mechanism to ShellIn...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
@jongyoul @prabhjyotsingh I excluded `interpreter-setting.json` and also rebased from master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #956: [ZEPPELIN-923] Apply new mechanism to ShellIn...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #956: [ZEPPELIN-923] Apply new mechanism to ShellIn...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
@jongyoul I see. Okay Thanks for letting me know :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #956: [ZEPPELIN-923] Apply new mechanism to ShellIn...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
@AhyoungRyu One looks irrelevant and another is about rat plugin. you need to exclude interpreter-setting.json in a rat plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---