You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2025/12/10 09:35:30 UTC
[PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
yiguolei opened a new pull request, #58908:
URL: https://github.com/apache/doris/pull/58908
### What problem does this PR solve?
<img width="977" height="876" alt="image" src="https://github.com/user-attachments/assets/4c3c5dc3-779c-4877-9f24-b251e3fd10b1" />
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58908:
URL: https://github.com/apache/doris/pull/58908#issuecomment-3639717053
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58908:
URL: https://github.com/apache/doris/pull/58908#issuecomment-3636780413
<details>
<summary>TPC-DS: <b>Total hot run time: 183541 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bf92c72c96710c73410c5de1f7a9902b043e88e0, data reload: false
query5 4678 667 486 486
query6 373 259 238 238
query7 4235 488 292 292
query8 337 290 268 268
query9 8784 2613 2647 2613
query10 487 405 370 370
query11 15288 14972 14615 14615
query12 200 125 147 125
query13 1281 519 445 445
query14 5887 3286 3080 3080
query14_1 2902 2947 2909 2909
query15 213 205 181 181
query16 875 492 492 492
query17 1173 742 629 629
query18 2447 458 377 377
query19 241 276 219 219
query20 132 117 115 115
query21 225 142 121 121
query22 3876 3993 3971 3971
query23 16645 16138 15936 15936
query23_1 16180 16216 16065 16065
query24 7476 1680 1276 1276
query24_1 1260 1277 1249 1249
query25 592 519 473 473
query26 1273 285 175 175
query27 2736 496 318 318
query28 4487 2208 2193 2193
query29 858 629 484 484
query30 325 250 222 222
query31 829 709 619 619
query32 83 77 72 72
query33 569 359 318 318
query34 914 922 557 557
query35 802 826 753 753
query36 873 925 815 815
query37 129 103 86 86
query38 3854 3819 3776 3776
query39 785 751 734 734
query39_1 866 870 720 720
query40 239 147 131 131
query41 83 80 77 77
query42 111 110 114 110
query43 440 437 421 421
query44 1364 773 768 768
query45 203 201 187 187
query46 890 991 624 624
query47 1663 1695 1600 1600
query48 334 339 270 270
query49 664 475 391 391
query50 689 296 235 235
query51 3774 3790 3837 3790
query52 112 121 101 101
query53 331 354 301 301
query54 316 292 290 290
query55 92 85 77 77
query56 333 341 353 341
query57 1149 1142 1091 1091
query58 302 290 279 279
query59 2402 2465 2392 2392
query60 347 347 333 333
query61 230 236 227 227
query62 744 695 637 637
query63 341 312 308 308
query64 5412 1631 1346 1346
query65 4106 3979 3971 3971
query66 1532 522 393 393
query67 15162 15266 14739 14739
query68 5786 1031 763 763
query69 533 385 340 340
query70 1083 1016 1010 1010
query71 380 333 300 300
query72 6309 5192 5132 5132
query73 676 545 321 321
query74 8829 8811 8711 8711
query75 3592 3572 3195 3195
query76 3896 1163 765 765
query77 556 411 300 300
query78 9590 9648 8856 8856
query79 1663 874 629 629
query80 964 689 647 647
query81 538 278 237 237
query82 420 135 116 116
query83 280 270 250 250
query84 268 134 109 109
query85 1050 642 606 606
query86 413 312 287 287
query87 4093 4049 3969 3969
query88 3281 2318 2333 2318
query89 477 426 401 401
query90 2122 164 164 164
query91 206 192 171 171
query92 82 77 69 69
query93 1416 931 583 583
query94 544 343 297 297
query95 595 353 381 353
query96 594 467 208 208
query97 2586 2731 2589 2589
query98 228 199 193 193
query99 1277 1293 1245 1245
Total cold run time: 263162 ms
Total hot run time: 183541 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58908:
URL: https://github.com/apache/doris/pull/58908#issuecomment-3636739504
<details>
<summary>TPC-H: <b>Total hot run time: 36517 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bf92c72c96710c73410c5de1f7a9902b043e88e0, data reload: false
------ Round 1 ----------------------------------
q1 17617 4505 4206 4206
q2 2003 389 242 242
q3 10157 1438 777 777
q4 10203 875 314 314
q5 7523 2359 2160 2160
q6 209 182 138 138
q7 1130 924 732 732
q8 9390 1643 1293 1293
q9 7345 5572 5610 5572
q10 6932 2433 2003 2003
q11 564 330 314 314
q12 695 746 570 570
q13 17798 3866 3027 3027
q14 311 299 276 276
q15 610 531 513 513
q16 939 922 886 886
q17 736 940 529 529
q18 8334 7289 7114 7114
q19 1113 1124 657 657
q20 402 379 250 250
q21 4375 4030 3978 3978
q22 1041 1038 966 966
Total cold run time: 109427 ms
Total hot run time: 36517 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4362 4307 4322 4307
q2 347 441 321 321
q3 2208 2791 2332 2332
q4 1359 1801 1303 1303
q5 5275 4670 4594 4594
q6 258 185 133 133
q7 2157 1991 1826 1826
q8 2941 2957 2701 2701
q9 7459 7573 7623 7573
q10 3242 3374 2899 2899
q11 665 532 509 509
q12 683 808 616 616
q13 3674 4102 3277 3277
q14 316 323 305 305
q15 663 554 525 525
q16 921 952 907 907
q17 1263 1616 1550 1550
q18 7931 7578 7676 7578
q19 879 918 985 918
q20 2039 2128 1940 1940
q21 4738 4411 4198 4198
q22 1104 1031 975 975
Total cold run time: 54484 ms
Total hot run time: 51287 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #58908:
URL: https://github.com/apache/doris/pull/58908#issuecomment-3636353731
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58908:
URL: https://github.com/apache/doris/pull/58908#issuecomment-3642114710
# BE UT Coverage Report
Increment line coverage `50.00% (4/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/bf92c72c96710c73410c5de1f7a9902b043e88e0_bf92c72c96710c73410c5de1f7a9902b043e88e0/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/bf92c72c96710c73410c5de1f7a9902b043e88e0_bf92c72c96710c73410c5de1f7a9902b043e88e0/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.46% (18839/35237) |
| Line Coverage | 39.21% (174252/444389) |
| Region Coverage | 33.87% (134998/398591) |
| Branch Coverage | 34.80% (58074/166879) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58908:
URL: https://github.com/apache/doris/pull/58908#issuecomment-3636178316
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58908:
URL: https://github.com/apache/doris/pull/58908#issuecomment-3642132051
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (8/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58908_bf92c72c96710c73410c5de1f7a9902b043e88e0_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58908_bf92c72c96710c73410c5de1f7a9902b043e88e0_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 72.23% (24831/34380) |
| Line Coverage | 58.86% (260501/442601) |
| Region Coverage | 53.69% (216160/402581) |
| Branch Coverage | 55.26% (92473/167355) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58908:
URL: https://github.com/apache/doris/pull/58908#issuecomment-3636798276
<details>
<summary>ClickBench: <b>Total hot run time: 27.56 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bf92c72c96710c73410c5de1f7a9902b043e88e0, data reload: false
query1 0.06 0.05 0.04
query2 0.10 0.05 0.05
query3 0.25 0.09 0.08
query4 1.61 0.11 0.11
query5 0.27 0.26 0.26
query6 1.15 0.64 0.65
query7 0.03 0.02 0.03
query8 0.05 0.04 0.04
query9 0.58 0.51 0.49
query10 0.56 0.55 0.55
query11 0.16 0.11 0.12
query12 0.15 0.11 0.11
query13 0.62 0.60 0.60
query14 0.99 0.98 0.98
query15 0.81 0.81 0.80
query16 0.39 0.42 0.39
query17 1.06 1.06 1.07
query18 0.23 0.21 0.21
query19 1.96 1.88 1.86
query20 0.01 0.02 0.01
query21 15.44 0.29 0.14
query22 4.51 0.05 0.05
query23 16.05 0.29 0.11
query24 1.37 0.58 0.37
query25 0.08 0.06 0.10
query26 0.15 0.13 0.15
query27 0.09 0.09 0.08
query28 3.67 1.22 1.02
query29 12.68 3.99 3.24
query30 0.29 0.14 0.12
query31 2.82 0.64 0.39
query32 3.24 0.54 0.45
query33 2.95 3.02 3.02
query34 16.77 5.21 4.54
query35 4.51 4.61 4.58
query36 0.65 0.50 0.49
query37 0.11 0.07 0.07
query38 0.07 0.04 0.04
query39 0.05 0.03 0.03
query40 0.17 0.13 0.13
query41 0.08 0.04 0.03
query42 0.04 0.03 0.03
query43 0.05 0.03 0.03
Total cold run time: 96.88 s
Total hot run time: 27.56 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58908:
URL: https://github.com/apache/doris/pull/58908#issuecomment-3639716988
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](memory_profile) should split memtable memory from task's memory profile [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #58908:
URL: https://github.com/apache/doris/pull/58908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org