[GitHub] [iotdb] HeimingZ commented on a diff in pull request #7087: [IOTDB-4210] Fix deadlock during WALNode recover

[GitBox <gi...@apache.org>]

HeimingZ commented on code in PR #7087:
URL: https://github.com/apache/iotdb/pull/7087#discussion_r952123111


##########
server/src/main/java/org/apache/iotdb/db/wal/recover/WALNodeRecoverTask.java:
##########
@@ -226,6 +226,9 @@ private void recoverTsFiles() {
                 WALFileUtils.walFilenameFilter(dir, name)
                     && WALFileUtils.parseVersionId(name) >= firstValidVersionId);
     if (walFiles == null) {
+      for (UnsealedTsFileRecoverPerformer recoverPerformer : memTableId2RecoverPerformer.values()) {
+        recoverPerformer.getRecoverListener().succeed();
+      }

Review Comment:
   Thank you for the bug fix, but UnsealedTsFileRecoverPerformer.endRecovery should be called before return success.
   
   ```suggestion
         for (UnsealedTsFileRecoverPerformer recoverPerformer : memTableId2RecoverPerformer.values()) {
         try {
           recoverPerformer.endRecovery();
           recoverPerformer.getRecoverListener().succeed();
         } catch (Exception e) {
           recoverPerformer.getRecoverListener().fail(e);
         }
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org