You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2019/12/23 00:44:46 UTC

[cordova-windows] branch brodybits-uwp-only-test-wip0499 updated: squash fix

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch brodybits-uwp-only-test-wip0499
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to refs/heads/brodybits-uwp-only-test-wip0499 by this push:
     new 008b5ec  squash fix
008b5ec is described below

commit 008b5ec4ec0bd75904731862701e5c47edccea4b
Author: Christopher J. Brody <ch...@brody.consulting>
AuthorDate: Sun Dec 22 19:44:29 2019 -0500

    squash fix
---
 spec/unit/build.spec.js       | 2 +-
 template/cordova/lib/build.js | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/spec/unit/build.spec.js b/spec/unit/build.spec.js
index 34e54af..c4ae315 100644
--- a/spec/unit/build.spec.js
+++ b/spec/unit/build.spec.js
@@ -284,7 +284,7 @@ describe('run method', function () {
         );
     });
 
-    it('spec.11 should call buildProject of MSBuildTools if built for windows phone 8.1', function () {
+    xit('spec.11 should call buildProject of MSBuildTools if built for windows phone 8.1', function () {
         var buildSpy = jasmine.createSpy();
 
         createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: buildSpy, path: testPath }]);
diff --git a/template/cordova/lib/build.js b/template/cordova/lib/build.js
index 44c33aa..23a3650 100644
--- a/template/cordova/lib/build.js
+++ b/template/cordova/lib/build.js
@@ -116,8 +116,7 @@ function getBuildTargets (isWinSwitch, isPhoneSwitch, projOverride, buildConfig)
         var windowsPhoneTargetVersion = configXML.getWindowsPhoneTargetVersion();
         switch (windowsPhoneTargetVersion.toLowerCase()) {
         case '8.1':
-            targets.push(projFiles.phone);
-            break;
+            throw new CordovaError('windows-phone 8.1 platform is deprecated - to use, downgrade to cordova-windows@7.');
         case '10.0':
         case 'uap':
         case 'uwp':


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org