You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by morissm <gi...@git.apache.org> on 2017/11/29 17:17:00 UTC
[GitHub] lucene-solr pull request #278: SOLR-11508: core.properties should be stored ...
GitHub user morissm opened a pull request:
https://github.com/apache/lucene-solr/pull/278
SOLR-11508: core.properties should be stored $solr.data.home/core_name
I ended up simply defaulting coreRootDirectory to solr.data.home, if it is defined, and solr.home.home otherwise.
Both values seem somewhat redundant but comments in SOLR-6671 indicate that others have reasons to keep them separate. This patch simply makes Solr behave in a way that is more intuitive by default.
Those who need to revert to the old way can define coreRootDirectory in solr.xml, if they hadn't already.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/morissm/lucene-solr jira/solr-11508
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #278
----
commit bb6795aa69b60d161e2226e1f4a9338199612edd
Author: Marc-Andre Morissette <ma...@gmail.com>
Date: 2017-11-29T16:46:09Z
SOLR-11508: core.properties should be stored $solr.data.home/core_name
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #278: SOLR-11508: core.properties should be stored $solr.d...
Posted by janhoy <gi...@git.apache.org>.
Github user janhoy commented on the issue:
https://github.com/apache/lucene-solr/pull/278
Looks good to me
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #278: SOLR-11508: core.properties should be stored ...
Posted by morissm <gi...@git.apache.org>.
Github user morissm closed the pull request at:
https://github.com/apache/lucene-solr/pull/278
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org