You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/08/16 21:06:56 UTC
[GitHub] [thrift] kainjow opened a new pull request #2440: THRIFT-5456: [c++] Disable SIGPIPE on TServerSocket
kainjow opened a new pull request #2440:
URL: https://github.com/apache/thrift/pull/2440
TSocketServer sets up many socket options, but unlike TSocket, it doesn't disable SIGPIPE.
One example for how this can be triggered is the server receives a request, but takes too long to process it. The sender then times out, and potentially closes its sockets. The server then completes the request, and then attempts to write back the result. Since the socket is now closed, a SIGPIPE signal is sent to the process, and if that signal isn't ignored, the process would crash, with a potential -13 exit code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2440: THRIFT-5456: Disable SIGPIPE on TServerSocket
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2440:
URL: https://github.com/apache/thrift/pull/2440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2440: THRIFT-5456: Disable SIGPIPE on TServerSocket
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2440:
URL: https://github.com/apache/thrift/pull/2440#issuecomment-910213955
Is this also missing in `TNonblockingServerSocket`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] kainjow commented on pull request #2440: THRIFT-5456: Disable SIGPIPE on TServerSocket
Posted by GitBox <gi...@apache.org>.
kainjow commented on pull request #2440:
URL: https://github.com/apache/thrift/pull/2440#issuecomment-945018997
> @kainjow any news here?
Will take a look soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2440: THRIFT-5456: Disable SIGPIPE on TServerSocket
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2440:
URL: https://github.com/apache/thrift/pull/2440#issuecomment-903299740
Could you trigger the build again, e.g. by force-pushing the branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] kainjow commented on pull request #2440: THRIFT-5456: Disable SIGPIPE on TServerSocket
Posted by GitBox <gi...@apache.org>.
kainjow commented on pull request #2440:
URL: https://github.com/apache/thrift/pull/2440#issuecomment-948233344
> TNonblockingServerSocket
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org