[GitHub] [lucene] benwtrent commented on pull request #12413: Fix HNSW graph visitation limit bug

["benwtrent (via GitHub)" <gi...@apache.org>]

benwtrent commented on PR #12413:
URL: https://github.com/apache/lucene/pull/12413#issuecomment-1620506450

   > Should we consider never exiting before hitting the zero-th level instead?
   
   🤔
   
   The idea is that if we cannot even get to the zeroth level before hitting the visitation limit, we shouldn't even bother going through the graph structure anymore as it will likely be slower than an exact match.
   
   I think exiting with nothing and indicating incomplete makes the most sense to me as it gives clear indication that searching the graph structure shouldn't be done. If we end early on the zeroth lauer we could give a "knn" that is nowhere near the actual kNN because we exited early on the zero-th layer.
   
   I don't know why that would be any better than exiting before reaching that layer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org