You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2024/01/05 13:12:20 UTC
[I] Tracking issues of RFC-3911: Deleter API [incubator-opendal]
Xuanwo opened a new issue, #3922:
URL: https://github.com/apache/incubator-opendal/issues/3922
- RFC: https://github.com/apache/incubator-opendal/pull/3911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "meteorgan (via GitHub)" <gi...@apache.org>.
meteorgan commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-3552704568
Eight months have passed and a lot has changed, I will take some time to revise #5762 later. Maybe we can just pick one solution for now, even if it's not perfect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-3549087332
We have two blockers for this issue. One is that we don’t yet support `recursive`—we’ve made some progress in https://github.com/apache/opendal/pull/5762, but it’s not clear how to move forward. The other is that we don’t yet support `concurrent`.
Other issues include implementing batch delete for OBS and implementing batch delete for versioned objects on OSS. We also need to check all services that support batch delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-3591749651
> Do we need a feature to delete all versions of a file or an entire path ?
Already supported by `op.delete_try_stream(op.lister_with(path).versions(true).await?).await?`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-3537472327
thanks @tisonkun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "meteorgan (via GitHub)" <gi...@apache.org>.
meteorgan commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-2493791963
Hi, @Xuanwo Have you started working on this issue ? I'm interested in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "meteorgan (via GitHub)" <gi...@apache.org>.
meteorgan commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-3591728581
Do we need a feature to delete all versions of a file or a path ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3922:
URL: https://github.com/apache/incubator-opendal/issues/3922#issuecomment-1887687314
Thanks a lot! Would like to submit a PR to fix them all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-2493797914
> Hi, @Xuanwo Have you started working on this issue ? I'm interested in it.
I'm currently working on this and will create separate tasks based on my progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-3537201902
@rich7420 Sure. Go ahead and feel free to ping me as a reviewer for your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [incubator-opendal]
Posted by "howiieyu (via GitHub)" <gi...@apache.org>.
howiieyu commented on issue #3922:
URL: https://github.com/apache/incubator-opendal/issues/3922#issuecomment-1887655690
If I understand correctly, there are a few typos in the RFC.
[L37](https://github.com/apache/incubator-opendal/blob/main/core/src/docs/rfcs/3911_deleter_api.md?plain=1#L37) in RFC text.
```diff
+ pub async fn delete_with(&self, path: &str) -> FutureDelete;
```
`delete_with` already return Future, `async` keyword is not necessary.
[L40](https://github.com/apache/incubator-opendal/blob/main/core/src/docs/rfcs/3911_deleter_api.md?plain=1#L40) in RFC text.
```diff
+ pub async fn deleter_with(&self) -> FutureDeleter;
```
same as above.
[L99](https://github.com/apache/incubator-opendal/blob/main/core/src/docs/rfcs/3911_deleter_api.md?plain=1#L99) in RFC text.
```rust
let deleter = op.deleter()
// Allow up to 8 concurrent delete tasks, default to 1.
.concurrent(8)
// Configure the buffer size to 1000, default value provided by services.
.buffer(1000)
.await?;
// Add a single file to the deleter.
deleter.delete(path).await?;
// Add a stream of files to the deleter.
deleter.delete_all(&mut lister).await?;
// Close deleter, make sure all input files are deleted.
deleter.close().await?;
```
`op.deleter()` should be `op.deleter_with()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-3536204365
Hello , could I try this issue ?
It seems that there still have some files in core and bindings needs to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-3585461174
> Eight months have passed and a lot has changed, I will take some time to revise [#5762](https://github.com/apache/opendal/pull/5762) later. Maybe we can just pick one solution for now, even if it's not perfect.
Oh, sorry for missing these comments. I’ve been working on this and have added https://github.com/apache/opendal/pull/6824, maybe you’ll be interested to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Tracking issues of RFC-3911: Deleter API [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3922:
URL: https://github.com/apache/opendal/issues/3922#issuecomment-3549093725
We have two blockers for this issue. One is that we don’t yet support `recursive`. we’ve made some progress in https://github.com/apache/opendal/pull/5762, but it’s not clear how to move forward. The other is that we don’t yet support `concurrent`.
Other issues include implementing batch delete for OBS and implementing batch delete for versioned objects on OSS. We also need to check all services that support batch delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org