You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphere.io> on 2013/10/31 23:55:42 UTC

Re: Review Request 15154: Preferred ng-show to jQuery for #no-leader-alert.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15154/
-----------------------------------------------------------

(Updated Oct. 31, 2013, 10:55 p.m.)


Review request for mesos.


Summary (updated)
-----------------

Preferred ng-show to jQuery for #no-leader-alert.


Repository: mesos-git


Description (updated)
-------

Preferred ng-show to jQuery for #no-leader-alert.

Mixing jQuery DOM access with Angular creates two locations for state
storage. Always prefer Angular to jQuery for changing the DOM.

* Removed the "Close" button because the alert is not dismissable.


Diffs
-----

  src/webui/master/static/index.html 47403d8dc407a454e011262d3614197e49f159ca 
  src/webui/master/static/js/controllers.js 0c930a2101af2d95bd003d8860602f9e3dd26fba 

Diff: https://reviews.apache.org/r/15154/diff/


Testing
-------


Thanks,

Ross Allen

Re: Review Request 15154: Preferred ng-show to jQuery for #no-leader-alert.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15154/#review27981
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Oct. 31, 2013, 10:55 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15154/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 10:55 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Preferred ng-show to jQuery for #no-leader-alert.
> 
> Mixing jQuery DOM access with Angular creates two locations for state
> storage. Always prefer Angular to jQuery for changing the DOM.
> 
> * Removed the "Close" button because the alert is not dismissable.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/index.html 47403d8dc407a454e011262d3614197e49f159ca 
>   src/webui/master/static/js/controllers.js 0c930a2101af2d95bd003d8860602f9e3dd26fba 
> 
> Diff: https://reviews.apache.org/r/15154/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ross Allen
> 
>